fix(fe2): SSR memory leak caused by vue apollo #3790
Conversation
| @@ -45,6 +45,7 @@ | |||
| } | |||
| }, | |||
| "peerDependencies": { | |||
| "vee-validate": "^4.7.0", | |||
There was a problem hiding this comment.
made it a peerDep so that it can be independently controlled
| @@ -77,7 +77,7 @@ | |||
| "tweetnacl-sealedbox-js": "^1.2.0", | |||
| "tweetnacl-util": "^0.15.1", | |||
| "ua-parser-js": "^1.0.38", | |||
| "vee-validate": "^4.7.0", | |||
| "vee-validate": "4.7.0", | |||
There was a problem hiding this comment.
there's been quite a few changes and I do want to upgrade to the latest version, but there's certain breaking changes so lets do it separately
| @@ -59,6 +59,7 @@ | |||
| "husky": "^7.0.4", | |||
| "lint-staged": "^12.3.7", | |||
| "lockfile": "^1.0.4", | |||
| "npkill": "^0.12.2", | |||
There was a problem hiding this comment.
Any reason for explicitly adding it as a dev dependency?
I npx npkill normally. But I don't see a script in package.json using it?
There was a problem hiding this comment.
i dislike using npx in a yarn project, because it uses an entirely different package manager to install the dep in a yarn project. you don't need a script in package.json, you can just do yarn npkill
| @@ -53,7 +53,7 @@ | |||
| "@tiptap/suggestion": "2.10.3", | |||
| "@tiptap/vue-3": "2.10.3", | |||
| "@tryghost/content-api": "^1.11.21", | |||
| "@vue/apollo-composable": "4.0.2", | |||
| "@vue/apollo-composable": "npm:@speckle/[email protected]", | |||
There was a problem hiding this comment.
Can you point to the source code of the fork please @fabis94 ?
(and add the link to the description of this PR please, so we can trace provenance)
There was a problem hiding this comment.
@iainsproat i added a link to the description
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
you can find the full source code of the fork as well as my specific changes through this PR: https://github.com/vuejs/apollo/pull/1582/files