-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): improved subscription testing DX + tests for common subs + new subs #3554
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4c81565
userProjectsUpdated.added test
fabis94 d00a8e4
multi region support
fabis94 4f22983
userStreamAdded
fabis94 152a5ab
commit subs tested
fabis94 4b3b10a
fix for proj workspace assignment
fabis94 739eb13
Merge branch 'main' into fabians/web-2168
fabis94 2745d9d
undo commitHelper main changes
fabis94 94a0510
disable all ffs mode
fabis94 7ced930
createTestWorkspace support when workspaces arent enabled
fabis94 0229287
project create fix
fabis94 9cc80d3
workspace projects updated subscription
fabis94 47ac74c
WIP new workspace sub
fabis94 3fa86b1
updated workspaceCreated
fabis94 90213c7
updated workspaceUpdated
fabis94 4351ba2
BE for workspace updated sub
fabis94 f395a95
workspace updated sub
fabis94 e6bc938
Merge branch 'main' into fabians/web-2168
fabis94 ab31934
ts err fix
fabis94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts error from previous code, @Mikehrn @andrewwallacespeckle plz check that TS linting works on ur end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabis94 Generally my linting is working as expected, but this never threw an error 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mikehrn it appears that vue-tsc, the CI linter doesn't pick up on this, which explains why it got through to main. in VSCode I definitely see squiggly lines in Dashboard.vue due to the type not being valid 🤔