Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): various useful multiregion changes from comments pr #3499

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Nov 15, 2024

i wanna get this out ASAP, cause they fix issues/bugs/errors in main

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

iainsproat
iainsproat previously approved these changes Nov 15, 2024
Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, though I didn't dig into the details.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

Copy link
Contributor

📸 Preview service has generated an image.

@fabis94 fabis94 requested a review from iainsproat November 15, 2024 10:44
@fabis94 fabis94 merged commit f961a6d into main Nov 15, 2024
26 of 28 checks passed
@fabis94 fabis94 deleted the fabians/mr-random-fixes1 branch November 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants