fix(logging): redact detail in database error message (#2642)

- may contain secrets which should not be logged
specklesystems · Aug 12, 2024 · a0a1363 · a0a1363
1 parent 595f76f
commit a0a1363
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/server/logging/knexMonitoring.ts b/packages/server/logging/knexMonitoring.ts
@@ -3,6 +3,7 @@ import { numberOfFreeConnections } from '@/modules/shared/helpers/dbHelper'
 import { type Knex } from 'knex'
 import { Logger } from 'pino'
 import { toNDecimalPlaces } from '@/modules/core/utils/formatting'
+import { omit } from 'lodash'
 
 export const initKnexPrometheusMetrics = (params: {
   db: Knex
@@ -162,7 +163,7 @@ export const initKnexPrometheusMetrics = (params: {
     metricQueryErrors.inc()
     params.logger.warn(
       {
-        err,
+        err: omit(err, 'detail'),
         sql: querySpec.sql,
         sqlMethod: normalizeSqlMethod(querySpec.method),
         sqlQueryId: queryId,