Update copy command in MkDocs build instruction to prevent copying to wrong location #1148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust copy command in the instruction to make it still copy individual subdirs inside
parser_output/mkdocs
dir (but not themkdocs
dir itself), even ifspdx-spec/docs/model/
andspdx-spec/docs/rdf
dirs are already exists.What is wrong?
If
spdx-spec/docs/model/
exists, the current command:will results this content inside the
spdx-spec/docs/model/
dir:which is not what we want. We want the subdirs to be copied at this level, as MkDocs expected.
What this PR do?
This PR update the command to:
mkdir -p spdx-spec/docs/model cp -R parser_output/mkdocs/* spdx-spec/docs/model
which will give this expected result in the
spdx-spec/docs/model/
dir, no matter if the dir exists before or not:This is new command also to prevent the case that the user may already have model subdirs inside
spdx-spec/docs/model/
dir from a previous run of spec generation and want to try another run. When they make copy with the current copy command, it will results to the below content (note themkdocs
subdir at the last row at the very end):This will lead to MkDocs errors.