Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support auto creation of all HLSPs #32

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Conversation

jotaylor
Copy link
Collaborator

Add ability to create STIS TSS, handle cases of STIS calibration where there is no acq image for plots, add SITS/G140L abut logic to wrapper.py

Copy link
Collaborator

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the timeseries code has a problem - there is code to rename all the _x1d.fits and _sx1.fits files to _without.fits, but in the routine the rename the files back to their original names (rename_files_back()), they all get renamed back to _x1d.fits. There's going to need to be code to rename back to file names by instrument

@jotaylor
Copy link
Collaborator Author

jotaylor commented Jun 7, 2022

Ok @stscirij sorry for the delay. Testing all this took a lot longer than I expected. I updated the renaming logic in timeseries.py and also had to make some changes to coadd.py so it can handle opening hundreds of files to make the TW Hydra files (we now have 2 epochs). I tested all of this and results look good, I also verified that normal coadd products were identical before and after the changes to coadd.py

@jotaylor
Copy link
Collaborator Author

jotaylor commented Jun 9, 2022

@stscirij look good now?

Copy link
Collaborator

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The comment was just an FYI for if you prefer to do it that way, nothing wrong with having the instantiation of the particular type of SegmentList out in the open for clarity

@jotaylor jotaylor merged commit 6a640a4 into main Jun 9, 2022
@jotaylor jotaylor deleted the dr5_hlsp_wrapper branch June 9, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants