-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support auto creation of all HLSPs #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the timeseries code has a problem - there is code to rename all the _x1d.fits and _sx1.fits files to _without.fits, but in the routine the rename the files back to their original names (rename_files_back()), they all get renamed back to _x1d.fits. There's going to need to be code to rename back to file names by instrument
Ok @stscirij sorry for the delay. Testing all this took a lot longer than I expected. I updated the renaming logic in timeseries.py and also had to make some changes to coadd.py so it can handle opening hundreds of files to make the TW Hydra files (we now have 2 epochs). I tested all of this and results look good, I also verified that normal coadd products were identical before and after the changes to coadd.py |
@stscirij look good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The comment was just an FYI for if you prefer to do it that way, nothing wrong with having the instantiation of the particular type of SegmentList out in the open for clarity
Add ability to create STIS TSS, handle cases of STIS calibration where there is no acq image for plots, add SITS/G140L abut logic to wrapper.py