-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace pyupgrade
isort
and black
with ruff format
#983
base: main
Are you sure you want to change the base?
replace pyupgrade
isort
and black
with ruff format
#983
Conversation
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
In order to actually make this a replacement for all the claimed tools, the rule sets for |
4e065ed
to
abeb810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, and I'm probably in favor of fewer moving pieces, which seems to be the goal of this PR.
But I do think we want to ~settle on some choice of code formatting, etc., and not mess with it very often. Does this represent that choice?
We can configure |
'build', | ||
] | ||
ignore = [ | ||
'E741', # ambiguous variable name | ||
] | ||
extend-select = ['NPY'] | ||
extend-include = ["*.ipynb"] | ||
|
||
[tool.ruff.lint.isort] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still is not selecting the rules for ruff to replace the pre-commit tooling this PR claims to be replacing. I'll open a PR against your branch fixing these issues.
This PR replaces the
pre-commit
checks forpyupgrade
,isort
, andblack
withruff format
Checklist
added entry inCHANGES.rst
under the corresponding subsectionupdated relevant testsupdated relevant documentationran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR