Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin numpy to >=1.22 #800

Merged
merged 1 commit into from
Jul 31, 2023
Merged

pin numpy to >=1.22 #800

merged 1 commit into from
Jul 31, 2023

Conversation

zacharyburnett
Copy link
Collaborator

NumPy <= 1.21 are no longer supported according to NEP 29.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Jul 31, 2023
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 31, 2023 17:19
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 31, 2023
ddavis-stsci
ddavis-stsci approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (we're currently running with numpy-1.25.1)

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d4366f7) 76.95% compared to head (ebd80d2) 76.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files          94       94           
  Lines        5694     5694           
=======================================
  Hits         4382     4382           
  Misses       1312     1312
Flag Coverage Δ *Carryforward flag
nightly 64.13% <ø> (ø) Carriedforward from d4366f7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett merged commit b4adc47 into spacetelescope:main Jul 31, 2023
21 checks passed
@zacharyburnett zacharyburnett deleted the numpy_pin branch July 31, 2023 17:39
@zacharyburnett zacharyburnett mentioned this pull request Jul 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddavis-stsci ddavis-stsci ddavis-stsci approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @ddavis-stsci