Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rcal 504 develop the resample step #787

Merged
merged 97 commits into from
Oct 21, 2023
Merged

Rcal 504 develop the resample step #787

merged 97 commits into from
Oct 21, 2023

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Jul 20, 2023 •
edited
Loading

Resolves RCAL-504

This PR addresses the implementation of the resampling step in RomanCal.

Notes
This PR depends on stcal's PR 196 (it uses the newly implemented alignment sub-package)

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@github-actions github-actions bot added assign_wcs dependencies Pull requests that update a dependency file labels Jul 20, 2023
@mairanteodoro mairanteodoro reopened this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Attention: 179 lines in your changes are missing coverage. Please review.

Files Coverage Δ
romancal/assign_wcs/assign_wcs_step.py 86.66% <100.00%> (+1.66%) ⬆️
romancal/datamodels/container.py 88.28% <ø> (ø)
romancal/lib/suffix.py 94.28% <ø> (ø)
romancal/regtest/regtestdata.py 68.35% <ø> (ø)
romancal/resample/__init__.py 100.00% <100.00%> (ø)
romancal/step.py 100.00% <100.00%> (ø)
romancal/stpipe/integration.py 100.00% <ø> (ø)
romancal/assign_wcs/utils.py 85.71% <81.81%> (-0.80%) ⬇️
romancal/resample/gwcs_drizzle.py 80.68% <80.68%> (ø)
romancal/resample/resample_utils.py 68.22% <65.55%> (-15.11%) ⬇️
... and 2 more

📢 Thoughts on this report? Let us know!.

@github-actions github-actions bot added documentation Improvements or additions to documentation pipeline labels Aug 3, 2023
@github-actions github-actions bot removed documentation Improvements or additions to documentation pipeline labels Aug 3, 2023
mairanteodoro and others added 2 commits August 10, 2023 11:03
@mairanteodoro
First functional implementation.
95c7d16
@ddavis-stsci @pre-commit-ci @mairanteodoro
Rcal 596 Add association processing to the pipeline code (spacetelesc…
220e4ea 
…ope#802)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This was referenced Oct 20, 2023
Closed
Closed
Closed
@nden
Copy link
Collaborator

nden commented Oct 20, 2023

The problem with weight_type='exptime' is fixed. I did not review in detail this time around but had done so previously.

@mairanteodoro mairanteodoro merged commit e8f562c into spacetelescope:main Oct 21, 2023
24 of 26 checks passed
@braingram braingram mentioned this pull request Oct 23, 2023
Closed
This was referenced Oct 24, 2023
Closed
Closed
Closed
Closed
ddavis-stsci added a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
@mairanteodoro @pre-commit-ci
@nden @ddavis-stsci @WilliamJamieson @stscieisenhamer @bmorris3 @zacharyburnett
Rcal 504 develop the resample step (spacetelescope#787)
2394aba 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nadia Dencheva <[email protected]>
Co-authored-by: D Davis <[email protected]>
Co-authored-by: William Jamieson <[email protected]>
Co-authored-by: Jonathan Eisenhamer <[email protected]>
Co-authored-by: Jonathan Eisenhamer <[email protected]>
Co-authored-by: Brett M. Morris <[email protected]>
Co-authored-by: Zach Burnett <[email protected]>
Co-authored-by: Zach Burnett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett left review comments

@mcara mcara mcara requested changes

@nden nden nden approved these changes

Assignees
No one assigned
Labels
assign_wcs dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation pipeline regression_testing stpipe testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mairanteodoro @nden @mcara @zacharyburnett @ddavis-stsci @WilliamJamieson @stscieisenhamer @bmorris3