Use mask when making segmentation image. #1574
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tddesjardins , can you see if this addresses your issue? |
|
@larrybradley , it would be nice to get your thoughts here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
+ Coverage 77.94% 77.97% +0.03%
==========================================
Files 115 115
Lines 7622 7628 +6
==========================================
+ Hits 5941 5948 +7
+ Misses 1681 1680 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some DQ bits to the mask used for computing the segmentation image. Those bits were also used for the PSF fitting. Because the two masks did not agree, it was possible for sources to be created consisting of fully masked pixels, which would cause problems when fitting PSFs to the fully masked regions.
This PR as currently constructed is a bit of a hack.
so we should not merge this PR. But I am hoping it is a useful starting point for discussions of the problem.