-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPF viewer: marker/mouseover support #104
Conversation
7463f7c
to
d6f6e3e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 93.92% 92.18% -1.75%
==========================================
Files 37 39 +2
Lines 1598 1945 +347
==========================================
+ Hits 1501 1793 +292
- Misses 97 152 +55 ☔ View full report in Codecov by Sentry. |
c2f2199
to
aa7f334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to be clear – I have approved so we can merge once we add units or decide to do that later, fix the time column in the exported marker table, and tests pass. |
Added the time unit - good catch. I'm a bit conflicted on the handling of reference time to get back to JD, etc. If the x-axes and mouseover show |
This PR adds full mouseover information and marker plugin support for the TPF viewer.