Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPF viewer: marker/mouseover support #104

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 12, 2024

This PR adds full mouseover information and marker plugin support for the TPF viewer.

@kecnry kecnry marked this pull request as draft April 12, 2024 13:02
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.18%. Comparing base (7b78df5) to head (b41fbca).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
lcviz/plugins/coords_info/coords_info.py 68.25% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   93.92%   92.18%   -1.75%     
==========================================
  Files          37       39       +2     
  Lines        1598     1945     +347     
==========================================
+ Hits         1501     1793     +292     
- Misses         97      152      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review April 12, 2024 14:11
@kecnry kecnry requested a review from bmorris3 April 12, 2024 14:11
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me with jdaviz==3.9.0.

One important thing: when you run

markers = lcviz.plugins['Markers']
markers.export_table()

you get a table with the times in the dt units. Let's transform those to proper JD/MJD before export:

Screen Shot 2024-04-19 at 11 07 57

lcviz/plugins/coords_info/coords_info.py Show resolved Hide resolved
lcviz/plugins/coords_info/coords_info.py Show resolved Hide resolved
@bmorris3
Copy link
Contributor

And to be clear – I have approved so we can merge once we add units or decide to do that later, fix the time column in the exported marker table, and tests pass.

@kecnry
Copy link
Member Author

kecnry commented Apr 19, 2024

Added the time unit - good catch.

I'm a bit conflicted on the handling of reference time to get back to JD, etc. If the x-axes and mouseover show dt, then I think it makes sense for that to be maintained during export. But maybe we could/should include the reference time in the table as well? Or maybe we just really need to think about reference time in general and have its behavior configured in a plugin (this is on our roadmap 🐱, but we haven't really fleshed out what that would look like yet). Thoughts? Maybe we should defer that for now and link back to this discussion for when we take on that effort?

@kecnry kecnry merged commit 3afe010 into spacetelescope:main Apr 22, 2024
8 of 11 checks passed
@kecnry kecnry deleted the tpf-marker-support branch April 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants