Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test similar to lcviz #2747

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 11, 2024

Description

This pull request is to add a test plaguing spacetelescope/lcviz#93 but for specviz.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 11, 2024
@pllim pllim added this to the 3.9 milestone Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (f9c348e) to head (d7a3e97).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
- Coverage   88.92%   88.63%   -0.30%     
==========================================
  Files         108      108              
  Lines       16003    16210     +207     
==========================================
+ Hits        14230    14367     +137     
- Misses       1773     1843      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review March 11, 2024 21:11
@pllim
Copy link
Contributor Author

pllim commented Mar 11, 2024

Didn't fail here. Not sure if you want this test or not...

@pllim pllim merged commit 6c09924 into spacetelescope:main Mar 21, 2024
15 of 16 checks passed
@pllim pllim deleted the tst-specviz-reset-limits branch March 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive specviz testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants