Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Handle second warning in test_all_nan_uncert_subset #2656

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 8, 2024

Description

This pull request is to handle second warning in test_all_nan_uncert_subset because pytest 8 will turn it into exception but it is hidden in older pytest. Noticed this in #2654 when pytest 8.0rc1 doesn't crash for other reasons (log: https://github.com/spacetelescope/jdaviz/actions/runs/7450389588/job/20269179809?pr=2654).

You can prove this to yourselves by pip install pytest --pre -U locally and then run the test suite.

xref #2643

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

because pytest 8 will turn it into exception but it is hidden in older pytest.
@pllim pllim added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.8.x on-merge: backport to v3.8.x labels Jan 8, 2024
@pllim pllim added this to the 3.8.2 milestone Jan 8, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (03edac6) 91.53% compared to head (4e218ac) 91.53%.

Files Patch % Lines
...default/plugins/model_fitting/tests/test_plugin.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
- Coverage   91.53%   91.53%   -0.01%     
==========================================
  Files         161      161              
  Lines       20056    20062       +6     
==========================================
+ Hits        18358    18363       +5     
- Misses       1698     1699       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review January 8, 2024 19:38
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes locally with 8.0.0rc1, thanks.

@pllim pllim merged commit 410d2f2 into spacetelescope:main Jan 8, 2024
25 of 28 checks passed
@pllim pllim deleted the handle-modeling-warn-pytest-8 branch January 8, 2024 20:05
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 8, 2024
pllim added a commit that referenced this pull request Jan 8, 2024
…6-on-v3.8.x

Backport PR #2656 on branch v3.8.x (TST: Handle second warning in test_all_nan_uncert_subset)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants