-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the bounding_box in inverse transforms #498
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 87.42% 87.16% -0.27%
==========================================
Files 22 22
Lines 3874 3941 +67
==========================================
+ Hits 3387 3435 +48
- Misses 487 506 +19 ☔ View full report in Codecov by Sentry. |
@bmorris3 Do you mind testing this PR with your code? |
@Cadair Can you take a look at this PR and see if it's OK for sun related code? |
84a85d2
to
12692ac
Compare
12692ac
to
404d692
Compare
Fixes #496
This fixes a bug in filtering out coordinates that are outside the footprint when evaluating the inverse transform. This affects also the
in_image
function. Previously the output of the backward transform was compared to the bounding_box and values outside it were replaced by NaNs. This PR adds an second step which is run before evaluating the backward transform and assigns output of NaN to inputs outside the footprint.