Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pixel_shape to WCS converter #480

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 12, 2023

Fixes: #474

Schema changes to add pixel_shape to the wcs schema are included in:
asdf-format/asdf-wcs-schemas#56

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b571a9) 87.25% compared to head (f765464) 87.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   87.25%   87.28%   +0.02%     
==========================================
  Files          22       22              
  Lines        3814     3821       +7     
==========================================
+ Hits         3328     3335       +7     
  Misses        486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden
Copy link
Collaborator

nden commented Nov 28, 2023

LGTM. Should a wcs_schemas release be made so this can pick up the change?

@braingram braingram marked this pull request as ready for review November 28, 2023 21:45
@braingram braingram requested a review from a team as a code owner November 28, 2023 21:45
@braingram
Copy link
Collaborator Author

Releasing asdf-wcs-schemas once asdf-format/asdf-wcs-schemas#56 sounds good.

The changes here are compatible with the existing 1.1.0 schema (it allows additionalProperties). I don't think the asdf-wcs-schemas release needs to be coordinated with any gwcs release. The conditions for a user could be as follows:

  • current asdf-wcs-schema, current gwcs: current behavior (no pixel_shape round-tripping)
  • new asdf-wcs-schema (with new wcs manifest), current gwcs: current behavior
  • current asdf-wcs-schema, new gwcs: pixel_shape round-tripping (but the written pixel_shape will not be validated as the wcs-1.2.0 schema will not be available)
  • new asdf-wcs-schema, new gwcs: pixel_shape round-tripping and validation

@nden nden merged commit 9d21ec0 into spacetelescope:master Nov 28, 2023
22 of 23 checks passed
@braingram braingram deleted the pixel_shape branch November 28, 2023 22:03
@nden nden added the APE 14 label Nov 28, 2023
@nden nden modified the milestones: 0.19, 0.20 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCS API and serialization
2 participants