Remove spacelog dependency #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger implementation from spacemonkeygo uses reflect, which increases binary size massively. Binary size is reduced from 9MB to 7MB for mender, which is quite a lot on an embedded target. Remove all references to github.com/spacemonkeygo/spacelog. Signed-off-by: Torben Hohn <[email protected]> Reviewed-by: Bastian Germann <[email protected]>
spacelog is not needed anymore. Remove it from the go module files. Signed-off-by: Torben Hohn <[email protected]> Reviewed-by: Bastian Germann <[email protected]>
amanelis
added a commit
to block27/openssl
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spacelog increases binary size massively, because it uses reflect, and it seems
that DCE can not do its job properly.