Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solana-sdk dependency #68

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Update solana-sdk dependency #68

merged 2 commits into from
Jul 24, 2024

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jul 23, 2024

This updates the solana-sdk dependency. The currently used version is already quite old and dependabot cannot automatically update it to the most recent version.

@fasmat fasmat requested a review from lrettig July 23, 2024 11:31
@fasmat fasmat self-assigned this Jul 23, 2024
Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like solana-sdk v2 is currently unreleased: https://github.com/solana-labs/solana/blob/master/CHANGELOG.md.

Shouldn't we stick with the latest stable release? Right now that's v1.17

@fasmat
Copy link
Member Author

fasmat commented Jul 24, 2024

Updated to use the newest v1.17.x.

@fasmat fasmat requested a review from lrettig July 24, 2024 08:10
@fasmat
Copy link
Member Author

fasmat commented Jul 24, 2024

Do we need the dependency on solana-sdk? As far as I can see we are only using it for creating ed25519 keys. Thats a big dependency for a relatively small task. We could use a smaller library like https://github.com/dalek-cryptography/curve25519-dalek, wdyt?

@lrettig
Copy link
Member

lrettig commented Jul 24, 2024

Do we need the dependency on solana-sdk? As far as I can see we are only using it for creating ed25519 keys. Thats a big dependency for a relatively small task. We could use a smaller library like https://github.com/dalek-cryptography/curve25519-dalek, wdyt?

Yes, we appear to only be using it for key management and signatures. It is a big dependency for a small task. We anyway need to update smcli to support the new ledger app, so maybe we just do an overhaul at that time.

@fasmat fasmat merged commit cd760de into main Jul 24, 2024
1 check passed
@fasmat fasmat deleted the update-solana branch July 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants