Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Ledger flow #55

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Tweak Ledger flow #55

merged 3 commits into from
Aug 1, 2024

Conversation

brusherru
Copy link
Member

It closes #41:

  1. Use 0/0/0 as default derivation path for importing from Ledger device (will be improved later within Replicate Metamask's "Connect Hardware Wallet" flow #52)
  2. Show "Wrong Ledger device" modal in case User trying to sign transaction with Ledger, while connected Ledger device does not contain the corresponding key

@brusherru brusherru requested review from pigmej and dioexul July 30, 2024 11:09
@brusherru brusherru self-assigned this Jul 30, 2024
Copy link

You can preview the changes at : https://237f3d02.smapp-lite-prod.pages.dev

@brusherru brusherru merged commit 630a98a into main Aug 1, 2024
1 check passed
@brusherru brusherru deleted the tweak-41-ledger-improvements branch August 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak interaction using Ledger
2 participants