Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by not running test cases #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jaccokrijnen
Copy link

Fix the build by changing build-type to Simple, meaning that the tests are not run anymore. The tests were written with an old version (<2.0) of QuickCheck (which requires base <4) and could therefore not compile.

@jaccokrijnen
Copy link
Author

So it turns out that since cabal-1.24, you have to define a custom-build stanza in the .cabal file (which is not completely obvious: haskell/cabal#5278). Adding such a stanza also fixes it, but gives the following warning:

/home/jacco/projects/permutation/dist-newstyle/build/x86_64-linux/ghc-8.4.1/permutation-0.5.0.5/setup/setup.hs:14:11: warning: [-Wdeprecations]
    In the use of ‘runTests’
    (imported from Distribution.Simple, but defined in Distribution.Simple.UserHooks):
    Deprecated: "Please use the new testing interface instead!"
   |
14 |          {runTests=testing}
   |           ^^^^^^^^

And indeed, using the most recent cabal, the runTests hook is ignored (and even if it wasn't, it would probably fail similarly to the quickcheck error from https://travis-ci.org/spacekitteh/permutation/jobs/47721007)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant