Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated PR: Cookstyle Changes #116

Closed
wants to merge 2 commits into from
Closed

Conversation

kitchen-porter
Copy link
Contributor

Hey!
I ran Cookstyle 7.32.0 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with spec/fixtures/cookbooks/aptly_spec/.delivery/config.json

  • 2:14 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  • 4:13 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  • 5:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
  • 5:13 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  • 9:7 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
  • 10:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
  • 14:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
  • 14:16 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://rubystyle.guide#consistent-string-literals)
  • 16:3 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.

Issues found and resolved with spec/fixtures/cookbooks/aptly_spec/.delivery/project.toml

Issues found and resolved with: spec/fixtures/cookbooks/aptly_spec/.delivery/config.json

 - 2:14 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 4:13 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 5:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
 - 5:13 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 9:7 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
 - 10:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
 - 14:5 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.
 - 14:16 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 16:3 convention: Style/TrailingCommaInHashLiteral - Put a comma after the last item of a multiline hash.

Issues found and resolved with: spec/fixtures/cookbooks/aptly_spec/.delivery/project.toml

 - 15:8 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 16:8 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 21:10 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 22:13 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 23:10 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 24:9 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals
 - 28:11 convention: Style/StringLiterals - Prefer single-quoted strings when you don't need string interpolation or special symbols. https://rubystyle.guideconsistent-string-literals

Signed-off-by: kitchen-porter <[email protected]>
@kitchen-porter kitchen-porter requested a review from a team as a code owner February 25, 2022 00:05
Copy link
Contributor

@Raboo Raboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raboo Raboo added the Release: Patch Release to Chef Supermarket as a version patch when merged label Feb 25, 2022
@Stromweld Stromweld added the Skip: Announcements On Release this will not put a message in the #Announcements slack channel label May 2, 2024
@Stromweld Stromweld enabled auto-merge (squash) May 2, 2024 17:54
@Stromweld
Copy link

.delivery folder needs to be remove closing this PR.

@Stromweld Stromweld closed this May 2, 2024
auto-merge was automatically disabled May 2, 2024 18:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Patch Release to Chef Supermarket as a version patch when merged Skip: Announcements On Release this will not put a message in the #Announcements slack channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants