Clarify SymbolInformation.symbol uniqueness properties and signature_documentation.relative_path presence
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
force-pushed
the
patch-1
branch
2 times, most recently
from
b15ae29 to
055c2ed
Compare
mgsloan
changed the title
mgsloan
changed the title
signature_documentation.relative_path presence
mgsloan
added a commit
to mgsloan/rust-analyzer
that referenced
this pull request
Dec 26, 2024
I'm fairly sure this is more correct, and saves space(~90mb to 82mb for Zed's index). I'm checking in about this with SCIP folks in sourcegraph/scip#299.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this because I think that while probably obvious, this is an important property that I couldn't find directly described
I also wanted to check that this assumption is correct, as I'm encountering duplicate entries in rust-analyzer's scip output. Specifically this file has two SymbolInformation entries both with the
symbolfield value ofrust-analyzer cargo gpui 0.1.0 shared_uri/fmt().(self)"