Remove extra bounds check

sourcegraph · May 2, 2024 · d9cdd41 · d9cdd41
1 parent 37c1600
commit d9cdd41
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bindings/go/scip/source_file.go b/bindings/go/scip/source_file.go
@@ -69,7 +69,7 @@ func (d *SourceFile) String() string {
 // RangeText returns the substring of the source file contents that enclose the provided range.
 func (d *SourceFile) RangeText(position Range) string {
 	result := strings.Builder{}
-	for line := position.Start.Line; line <= position.End.Line && int(line) < len(d.Lines); line++ {
+	for line := position.Start.Line; line <= position.End.Line; line++ {
 		start := position.Start.Character
 		if line > position.Start.Line {
 			result.WriteString("\n")

diff --git a/bindings/go/scip/source_file_test.go b/bindings/go/scip/source_file_test.go
@@ -23,7 +23,7 @@ func TestRangeText(t *testing.T) {
 		{range_: []int32{0, 0, 0, 8}, expect: autogold.Expect("Mary had")},
 		{range_: []int32{0, 0, 1, 0}, expect: autogold.Expect("Mary had a little lamb,\n")},
 		{range_: []int32{0, 0, 1, 10}, expect: autogold.Expect("Mary had a little lamb,\nIts fleece")},
-		{range_: []int32{0, 0, 5, 0}, expect: autogold.Expect(`Mary had a little lamb,
+		{range_: []int32{0, 0, 4, 0}, expect: autogold.Expect(`Mary had a little lamb,
 Its fleece was white as snow.
 And everywhere that Mary went,
 The lamb was sure to go.