Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output #703

Closed
wants to merge 1 commit into from

Conversation

JamyDev
Copy link

@JamyDev JamyDev commented May 7, 2024

This change adds the SymbolInformation.Kind property to DocumentSymbols. The following changes were required to make this work:

  1. Updated the SCIP proto to the latest version from sourcegraph/scip (keeping the package the same to avoid a bunch of refactoring)
  2. Added a mapper to go from SemanticDb Kind to Scip Kind and called it during the SymbolInformation builder.

Test plan

There's no real way to validate the DocumentSymbols using the snapshot tests. Any recommendations for how to test this properly are appreciated!

@JamyDev
Copy link
Author

JamyDev commented May 7, 2024

I see that this is a duplicate of #677, will close if favor of that one.

@JamyDev JamyDev closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant