Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audoedit): add isRead field and postProcessed state to the analytics logger #6534

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

valerybugakov
Copy link
Member

  • Introduces a new postProcessed state to the autoedit suggestions lifecycle. This intermediate step is necessary for the agent API. Instead of transitioning the request directly to the suggested state, we first save the request's metadata in the analytics logger cache. This ensures the agent can access it using only the request ID during unstable_handleDidShowCompletionItem calls.
  • Adds the isRead field to the autoedits events metadata, which is crucial for calculating CAR and other metrics.
  • Updates unit tests to cover changes introduced in the PR.
  • Exposes autoeditIdRegistry as a singleton, which will be used in the autoedits provider integration tests in one of the follow-up PRs.

Test plan

CI + updated unit tests.

@valerybugakov valerybugakov self-assigned this Jan 6, 2025
abeatrix added a commit that referenced this pull request Jan 6, 2025
Skip the query rewrite step for the deep-cody agent, as this is already handled during the reflection/review step.
Copy link
Contributor

@hitesh-1997 hitesh-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@valerybugakov valerybugakov merged commit 8778bb5 into main Jan 7, 2025
22 checks passed
@valerybugakov valerybugakov deleted the vb/autoedits-analytics-logger-integration-5 branch January 7, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants