Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/release: Remove the changelog section from the PR template. #6470

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dominiccooney
Copy link
Contributor

This section of the PR template isn't used by any tools. In practice people don't fill it out and it just contributes to noise in the git log.

Test plan

GitHub template only change.

@dominiccooney dominiccooney enabled auto-merge (squash) December 27, 2024 06:05
@kalanchan
Copy link
Contributor

#6243

tooling is in review, let's keep the changelog section and actually start enforcing it :)

@ichim-david
Copy link
Contributor

#6243

tooling is in review, let's keep the changelog section and actually start enforcing it :)

@kalanchan if you guys plan on keeping the link and enforcing a commit standard I think you should
open the notion page to the general public. I as a regular user who has contributed to this repo
cannot access it and as such I don't know what I need to follow.

@kalanchan
Copy link
Contributor

#6243
tooling is in review, let's keep the changelog section and actually start enforcing it :)

@kalanchan if you guys plan on keeping the link and enforcing a commit standard I think you should open the notion page to the general public. I as a regular user who has contributed to this repo cannot access it and as such I don't know what I need to follow.

oh yes, thank you for that! I'll look into how we can make public the notion page or just update the contribution guidelines once the tooling is ready!

@dominiccooney
Copy link
Contributor Author

@kalanchan let's add this back when the automation is there. It is easy to add back, just revert this change.

@kalanchan
Copy link
Contributor

@kalanchan let's add this back when the automation is there. It is easy to add back, just revert this change.

WAIT IT'S so close, give me by end of week to finish it! Anish and I just need to fix up the tooling so that it can handle Cody PRs and it'll be ready

@dominiccooney dominiccooney merged commit 2901fe7 into main Jan 10, 2025
18 of 19 checks passed
@dominiccooney dominiccooney deleted the dpc/no-changelog-in-pull-request-template branch January 10, 2025 01:18
@dominiccooney
Copy link
Contributor Author

@kalanchan oh automerge was set.

But still, you have subject the team to six months of this template and trained them to ignore it... we have 349 instances of it in the commit history... When the automation is done, you can start to communicate what it is that you want to have happen there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants