Measuring node main thread occupancy #6223
Conversation
| } | ||
|
|
||
| private emitTelemetry(occupancy: number): void { | ||
| telemetryRecorder.recordEvent('cody.performance', 'threadOccupancy', { |
There was a problem hiding this comment.
@akalia25 Would doing something like this be acceptable from the frame of reference of the data team? Basically it will emit a telemetry event every 1 minute of usage. Is that something we can handle?
There was a problem hiding this comment.
Hey @arafatkatze, thanks for checking in with us! This could be a lot of events. When you say usage, is this active usage? Or does it still record when the IDE is idle?
It seems like this telemetry will be used for monitoring CPU usage (correct me if I'm wrong). I'd love to explore options on how we can limit this to ~1M events a day, if possible. :) ~ If this data is super important and will unlock a lot for us, let me know, and we can make it work with the current load.
Linear Issue
This pull request introduces a new feature to monitor the Node.js main thread occupancy within the VSCode extension. The feature aims to provide insights into the extension's performance by measuring CPU usage and emitting telemetry data.
Key Changes
ThreadOccupancyMonitor Class: A new class is added to measure the main thread's CPU usage at regular intervals. It calculates the occupancy percentage and maintains a rolling average. The ThreadOccupancyMonitor is initialized and started during the extension's activation process. It is also properly disposed of during deactivation to ensure clean resource management.
Proactive Alerts: Potential to set up alerts based on occupancy data to detect and address performance issues proactively.
Test plan
Tested in the Cody DEbugger that runs locally or you can use console.log to see the output of this
NOTE: This stuff is fairly straightforward so I assume I don't need any unit testing for this etc.
Changelog