Standardize imports

.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  extends: ['react-app', 'plugin:@typescript-eslint/recommended'],
+  plugins: ['no-relative-import-paths', 'simple-import-sort'],
+  rules: {
+    '@typescript-eslint/no-empty-function': 'off',
+    '@typescript-eslint/interface-name-prefix': 'off',
+    '@typescript-eslint/camelcase': 'off',
+    '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/explicit-module-boundary-types': 'off',
+    '@typescript-eslint/ban-ts-comment': 'warn',
+    '@typescript-eslint/ban-types': 'off',
+    'no-relative-import-paths/no-relative-import-paths': ['error', { allowSameFolder: true }],
+    'simple-import-sort/imports': 'error'
+  },
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx', '*.js', '*.jsx'].map(filename => `**/__tests__/**/${filename}`),
+      rules: {
+        'no-relative-import-paths/no-relative-import-paths': 'off'
+      }
+    }
+  ]
+};

package.json

@@ -121,6 +121,7 @@
     "coveralls": "^3.1.1",
     "cross-env": "^7.0.3",
     "enzyme": "^3.11.0",
+    "eslint-plugin-no-relative-import-paths": "^1.5.2",
     "eslint-plugin-simple-import-sort": "^7.0.0",
     "https-browserify": "^1.0.0",
     "husky": "^8.0.2",

src/commons/XMLParser/XMLParserHelper.ts

@@ -1,7 +1,5 @@
 import { Chapter } from 'js-slang/dist/types';
-import { Builder } from 'xml2js';
-
-import { ExternalLibraryName } from '../application/types/ExternalTypes';
+import { ExternalLibraryName } from 'src/commons/application/types/ExternalTypes';
 import {
   Assessment,
   AssessmentOverview,
@@ -17,7 +15,9 @@ import {
   Question,
   Testcase,
   TestcaseTypes
-} from '../assessment/AssessmentTypes';
+} from 'src/commons/assessment/AssessmentTypes';
+import { Builder } from 'xml2js';
+
 import {
   EDITING_ID,
   XmlParseStrCProblem,

src/commons/XMLParser/XMLParserTypes.ts

@@ -1,5 +1,5 @@
-import { ExternalLibraryName } from '../application/types/ExternalTypes';
-import { Question } from '../assessment/AssessmentTypes';
+import { ExternalLibraryName } from 'src/commons/application/types/ExternalTypes';
+import { Question } from 'src/commons/assessment/AssessmentTypes';
 
 export const EDITING_ID = -1;
 

src/commons/achievement/AchievementCard.tsx

@@ -2,8 +2,8 @@ import { Icon, Intent, ProgressBar } from '@blueprintjs/core';
 import { IconNames } from '@blueprintjs/icons';
 import { useContext } from 'react';
 import { AchievementContext, handleGlow } from 'src/features/achievement/AchievementConstants';
+import { AchievementStatus } from 'src/features/achievement/AchievementTypes';
 
-import { AchievementStatus } from '../../features/achievement/AchievementTypes';
 import AchievementDeadline from './card/AchievementDeadline';
 import AchievementXp from './card/AchievementXp';
 

src/commons/achievement/AchievementCommentCard.tsx

@@ -1,10 +1,9 @@
 import { useMemo } from 'react';
-
-import { Assessment } from '../assessment/AssessmentTypes';
-import { history } from '../utils/HistoryHelper';
-import { useTypedSelector } from '../utils/Hooks';
-import { showWarningMessage } from '../utils/NotificationsHelper';
-import { assessmentTypeLink } from '../utils/ParamParseHelper';
+import { Assessment } from 'src/commons/assessment/AssessmentTypes';
+import { history } from 'src/commons/utils/HistoryHelper';
+import { useTypedSelector } from 'src/commons/utils/Hooks';
+import { showWarningMessage } from 'src/commons/utils/NotificationsHelper';
+import { assessmentTypeLink } from 'src/commons/utils/ParamParseHelper';
 
 const AchievementCommentCard = ({
   assessment,

src/commons/achievement/AchievementFilter.tsx

@@ -1,7 +1,6 @@
 import { Icon, IconName } from '@blueprintjs/core';
-
-import { getFilterColor } from '../../features/achievement/AchievementConstants';
-import { FilterStatus } from '../../features/achievement/AchievementTypes';
+import { getFilterColor } from 'src/features/achievement/AchievementConstants';
+import { FilterStatus } from 'src/features/achievement/AchievementTypes';
 
 type AchievementFilterProps = {
   filterState: [FilterStatus, any];

src/commons/achievement/AchievementManualEditor.tsx

@@ -1,15 +1,14 @@
 import { Button, Checkbox, MenuItem, NumericInput } from '@blueprintjs/core';
 import { ItemPredicate, ItemRenderer, Select } from '@blueprintjs/select';
 import { useContext, useEffect, useState } from 'react';
+import { showSuccessMessage, showWarningMessage } from 'src/commons/utils/NotificationsHelper';
 import { AchievementContext } from 'src/features/achievement/AchievementConstants';
 import {
   AchievementGoal,
   AchievementUser,
   GoalProgress
 } from 'src/features/achievement/AchievementTypes';
 
-import { showSuccessMessage, showWarningMessage } from '../utils/NotificationsHelper';
-
 type AchievementManualEditorProps = {
   hiddenState: [boolean, any];
   userState: [AchievementUser | undefined, any];

src/commons/achievement/AchievementOverview.tsx

@@ -1,9 +1,9 @@
 import { useEffect } from 'react';
 import { useDispatch } from 'react-redux';
+import { FETCH_TOTAL_XP, FETCH_TOTAL_XP_ADMIN } from 'src/commons/application/types/SessionTypes';
+import { useTypedSelector } from 'src/commons/utils/Hooks';
 import { AchievementUser } from 'src/features/achievement/AchievementTypes';
 
-import { FETCH_TOTAL_XP, FETCH_TOTAL_XP_ADMIN } from '../application/types/SessionTypes';
-import { useTypedSelector } from '../utils/Hooks';
 import AchievementLevel from './overview/AchievementLevel';
 
 type AchievementOverviewProps = {

src/commons/achievement/AchievementTask.tsx

@@ -1,11 +1,8 @@
 import { Collapse } from '@blueprintjs/core';
 import React, { useContext, useState } from 'react';
+import { AchievementContext, getAbilityColor } from 'src/features/achievement/AchievementConstants';
+import { AchievementStatus, FilterStatus } from 'src/features/achievement/AchievementTypes';
 
-import {
-  AchievementContext,
-  getAbilityColor
-} from '../../features/achievement/AchievementConstants';
-import { AchievementStatus, FilterStatus } from '../../features/achievement/AchievementTypes';
 import AchievementCard from './AchievementCard';
 
 type AchievementTaskProps = {

src/commons/achievement/AchievementView.tsx

@@ -2,17 +2,20 @@ import { Icon } from '@blueprintjs/core';
 import { IconNames } from '@blueprintjs/icons';
 import { useContext, useEffect } from 'react';
 import { useDispatch } from 'react-redux';
-
+import {
+  FETCH_ASSESSMENT,
+  FETCH_ASSESSMENT_ADMIN
+} from 'src/commons/application/types/SessionTypes';
+import { FETCH_ASSESSMENT_OVERVIEWS } from 'src/commons/assessment/AssessmentTypes';
+import { Assessment } from 'src/commons/assessment/AssessmentTypes';
+import { useTypedSelector } from 'src/commons/utils/Hooks';
 import {
   AchievementContext,
   getAbilityBackground,
   getAbilityGlow
-} from '../../features/achievement/AchievementConstants';
-import { AchievementStatus, AchievementUser } from '../../features/achievement/AchievementTypes';
-import { FETCH_ASSESSMENT, FETCH_ASSESSMENT_ADMIN } from '../application/types/SessionTypes';
-import { FETCH_ASSESSMENT_OVERVIEWS } from '../assessment/AssessmentTypes';
-import { Assessment } from '../assessment/AssessmentTypes';
-import { useTypedSelector } from '../utils/Hooks';
+} from 'src/features/achievement/AchievementConstants';
+import { AchievementStatus, AchievementUser } from 'src/features/achievement/AchievementTypes';
+
 import AchievementCommentCard from './AchievementCommentCard';
 import { prettifyDate } from './utils/DateHelper';
 import AchievementViewCompletion from './view/AchievementViewCompletion';

src/commons/achievement/card/AchievementDeadline.tsx

@@ -1,8 +1,11 @@
 import { Icon } from '@blueprintjs/core';
 import { IconNames } from '@blueprintjs/icons';
-
-import { DeadlineColors } from '../../../features/achievement/AchievementConstants';
-import { isExpired, prettifyDeadline, timeFromExpired } from '../utils/DateHelper';
+import {
+  isExpired,
+  prettifyDeadline,
+  timeFromExpired
+} from 'src/commons/achievement/utils/DateHelper';
+import { DeadlineColors } from 'src/features/achievement/AchievementConstants';
 
 type AchievementDeadlineProps = {
   deadline?: Date;

src/commons/achievement/control/AchievementPreview.tsx

@@ -1,12 +1,11 @@
 import { Button } from '@blueprintjs/core';
 import { IconNames } from '@blueprintjs/icons';
 import { useContext, useReducer, useState } from 'react';
+import AchievementView from 'src/commons/achievement/AchievementView';
 import { AchievementContext } from 'src/features/achievement/AchievementConstants';
 import { FilterStatus } from 'src/features/achievement/AchievementTypes';
 import { generateAchievementTasks } from 'src/pages/achievement/subcomponents/AchievementDashboard';
 
-import AchievementView from '../AchievementView';
-
 type AchievementPreviewProps = {
   awaitPublish: boolean;
   publishChanges: () => void;

src/commons/achievement/control/achievementEditor/AchievementTemplate.ts

@@ -1,11 +1,5 @@
-import {
-  cardBackgroundUrl,
-  coverImageUrl
-} from '../../../../features/achievement/AchievementConstants';
-import {
-  AchievementItem,
-  AchievementView
-} from '../../../../features/achievement/AchievementTypes';
+import { cardBackgroundUrl, coverImageUrl } from 'src/features/achievement/AchievementConstants';
+import { AchievementItem, AchievementView } from 'src/features/achievement/AchievementTypes';
 
 export const viewTemplate: AchievementView = {
   coverImage: `${coverImageUrl}/default.png`,

src/commons/achievement/control/achievementEditor/EditableCard.tsx

@@ -3,14 +3,11 @@ import { IconNames } from '@blueprintjs/icons';
 import { Tooltip2 } from '@blueprintjs/popover2';
 import { cloneDeep } from 'lodash';
 import { useContext, useMemo, useReducer, useState } from 'react';
+import ItemDeleter from 'src/commons/achievement/control/common/ItemDeleter';
+import ItemSaver from 'src/commons/achievement/control/common/ItemSaver';
+import { AchievementContext } from 'src/features/achievement/AchievementConstants';
+import { AchievementItem, AchievementView } from 'src/features/achievement/AchievementTypes';
 
-import { AchievementContext } from '../../../../features/achievement/AchievementConstants';
-import {
-  AchievementItem,
-  AchievementView
-} from '../../../../features/achievement/AchievementTypes';
-import ItemDeleter from '../common/ItemDeleter';
-import ItemSaver from '../common/ItemSaver';
 import AchievementSettings from './AchievementSettings';
 import AchievementUuidCopier from './AchievementUuidCopier';
 import {

src/commons/achievement/control/goalEditor/EditableGoal.tsx

@@ -1,11 +1,11 @@
 import { EditableText } from '@blueprintjs/core';
 import { cloneDeep } from 'lodash';
 import { useContext, useMemo, useReducer, useState } from 'react';
+import ItemDeleter from 'src/commons/achievement/control/common/ItemDeleter';
+import ItemSaver from 'src/commons/achievement/control/common/ItemSaver';
 import { AchievementContext } from 'src/features/achievement/AchievementConstants';
 import { GoalDefinition, GoalMeta } from 'src/features/achievement/AchievementTypes';
 
-import ItemDeleter from '../common/ItemDeleter';
-import ItemSaver from '../common/ItemSaver';
 import {
   EditableGoalAction as Action,
   EditableGoalActionType as ActionType,

src/commons/achievement/control/goalEditor/metaDetails/EditableEventMeta.tsx

@@ -2,11 +2,10 @@ import { Button, MenuItem, NumericInput } from '@blueprintjs/core';
 import { IconNames } from '@blueprintjs/icons';
 import { Tooltip2 } from '@blueprintjs/popover2';
 import { ItemRenderer, Select } from '@blueprintjs/select';
+import EditableDate from 'src/commons/achievement/control/goalEditor/EditableDate';
+import EditableTime from 'src/commons/achievement/control/goalEditor/EditableTime';
 import { EventMeta, EventType, GoalMeta } from 'src/features/achievement/AchievementTypes';
 
-import EditableDate from '../EditableDate';
-import EditableTime from '../EditableTime';
-
 type EditableEventMetaProps = {
   changeMeta: (meta: GoalMeta) => void;
   eventMeta: EventMeta;

src/commons/achievement/overview/AchievementLevel.tsx

@@ -1,8 +1,8 @@
 import { ProgressBar } from '@blueprintjs/core';
 import { useState } from 'react';
+import Constants from 'src/commons/utils/Constants';
+import { xpPerLevel } from 'src/features/achievement/AchievementConstants';
 
-import { xpPerLevel } from '../../../features/achievement/AchievementConstants';
-import Constants from '../../utils/Constants';
 import AchievementMilestone from './AchievementMilestone';
 
 type AchievementLevelProps = {

src/commons/achievement/overview/AchievementMilestone.tsx

@@ -1,4 +1,4 @@
-import Constants from '../../utils/Constants';
+import Constants from 'src/commons/utils/Constants';
 
 type AchievementMilestoneProps = {
   studentXp: number;

src/commons/achievement/utils/AchievementBackender.ts

@@ -4,7 +4,7 @@ import {
   GoalDefinition,
   GoalMeta,
   GoalType
-} from '../../../features/achievement/AchievementTypes';
+} from 'src/features/achievement/AchievementTypes';
 
 export const backendifyGoalDefinition = (goal: GoalDefinition) => ({
   targetCount: goal.meta.type === GoalType.ASSESSMENT ? 1 : goal.meta.targetCount,

src/commons/achievement/utils/AchievementInferencer.ts

@@ -1,6 +1,5 @@
 import { cloneDeep, uniq } from 'lodash';
-import { v4 } from 'uuid';
-
+import { showDangerMessage } from 'src/commons/utils/NotificationsHelper';
 import {
   AchievementGoal,
   AchievementItem,
@@ -9,8 +8,9 @@ import {
   GoalDefinition,
   GoalProgress,
   GoalType
-} from '../../../features/achievement/AchievementTypes';
-import { showDangerMessage } from '../../utils/NotificationsHelper';
+} from 'src/features/achievement/AchievementTypes';
+import { v4 } from 'uuid';
+
 import { isExpired, isReleased } from './DateHelper';
 
 /**

src/commons/achievement/utils/EventHandler.ts

@@ -1,12 +1,13 @@
+import { showSuccessMessage } from 'src/commons/utils/NotificationsHelper';
 import {
   AchievementGoal,
   AchievementItem,
   EventMeta,
   EventType,
   GoalProgress,
   GoalType
-} from '../../../features/achievement/AchievementTypes';
-import { showSuccessMessage } from '../../utils/NotificationsHelper';
+} from 'src/features/achievement/AchievementTypes';
+
 import AchievementInferencer from './AchievementInferencer';
 import { isExpired, isReleased, isWithinTimeRange } from './DateHelper';
 

src/commons/achievement/utils/InsertFakeAchievements.ts

@@ -1,11 +1,11 @@
 import moment from 'moment';
-
 import {
-  cardBackgroundUrl,
-  coverImageUrl
-} from '../../../features/achievement/AchievementConstants';
-import { GoalType } from '../../../features/achievement/AchievementTypes';
-import { AssessmentConfiguration, AssessmentOverview } from '../../assessment/AssessmentTypes';
+  AssessmentConfiguration,
+  AssessmentOverview
+} from 'src/commons/assessment/AssessmentTypes';
+import { cardBackgroundUrl, coverImageUrl } from 'src/features/achievement/AchievementConstants';
+import { GoalType } from 'src/features/achievement/AchievementTypes';
+
 import AchievementInferencer from './AchievementInferencer';
 import { isExpired, isReleased } from './DateHelper';
 

src/commons/achievement/view/AchievementViewGoal.tsx

@@ -1,6 +1,5 @@
 import { ProgressBar } from '@blueprintjs/core';
-
-import { AchievementGoal } from '../../../features/achievement/AchievementTypes';
+import { AchievementGoal } from 'src/features/achievement/AchievementTypes';
 
 type AchievementViewGoalProps = {
   goals: AchievementGoal[];