Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several tool-info modules to BaseTool2 #646

Merged
merged 46 commits into from
Nov 3, 2020

Conversation

skanav
Copy link
Contributor

@skanav skanav commented Oct 25, 2020

updated tool info modules of verification (and validation) tools from sv-comp 20 to start using data models from the task dict.
this is required for the competition after PR 169 in benchmark definitions repo is merged

The following are still remaining:

  1. ultimate based tools - it is a bit more complicated. Should be dealt separately

@danieldietsch
Copy link
Contributor

Should I update the Ultimate tools? How soon is it needed?

@skanav
Copy link
Contributor Author

skanav commented Oct 26, 2020

Should I update the Ultimate tools?

This would be great.

How soon is it needed?

It would be needed for the preruns. So it should be done soon.

Copy link
Member

@PhilippWendler PhilippWendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have a few comments that I added. Many of these actually apply to more than one tool-info module but I always added them in only one location, so please check for each comment in which tool-info modules it also applies.

benchexec/util.py Outdated Show resolved Hide resolved
benchexec/tools/brick.py Outdated Show resolved Hide resolved
benchexec/tools/brick.py Show resolved Hide resolved
benchexec/tools/brick.py Outdated Show resolved Hide resolved
benchexec/tools/brick.py Show resolved Hide resolved
benchexec/tools/esbmc.py Outdated Show resolved Hide resolved
benchexec/tools/symbiotic.py Outdated Show resolved Hide resolved
benchexec/tools/symbiotic.py Outdated Show resolved Hide resolved
benchexec/tools/symbiotic.py Outdated Show resolved Hide resolved
benchexec/tools/two_ls.py Outdated Show resolved Hide resolved
@PhilippWendler PhilippWendler changed the title Ti update to base tool2 verifiers Update several tool-info modules to BaseTool2 Oct 26, 2020
@PhilippWendler
Copy link
Member

Just remembered sosy-lab/sv-benchmarks#1125, I think it would make sense to wait for a resolution of that issue before merging this PR.

@skanav skanav force-pushed the TI-update-to-BaseTool2-verifiers branch from 131b44a to 6f11a4c Compare October 28, 2020 11:52
benchexec/tools/cbmc.py Outdated Show resolved Hide resolved
benchexec/tools/cbmc.py Outdated Show resolved Hide resolved
benchexec/tools/divine.py Outdated Show resolved Hide resolved
benchexec/tools/divine.py Outdated Show resolved Hide resolved
benchexec/tools/divine4.py Outdated Show resolved Hide resolved
benchexec/tools/klee.py Outdated Show resolved Hide resolved
benchexec/tools/legion.py Outdated Show resolved Hide resolved
benchexec/tools/libkluzzer.py Outdated Show resolved Hide resolved
benchexec/tools/pinaka.py Outdated Show resolved Hide resolved
benchexec/tools/tracerx.py Outdated Show resolved Hide resolved
@MartinSpiessl
Copy link
Contributor

Just remembered sosy-lab/sv-benchmarks#1125, I think it would make sense to wait for a resolution of that issue before merging this PR.

Didn't seem like there is active work on sosy-lab/sv-benchmarks#1125, but I actually depend on this PR (doesn't the whole competition infrastructure need this?), so I would welcome if this could get merged quickly.

@MartinNowack
Copy link
Contributor

From my side, changes for KLEE look good.

@PhilippWendler
Copy link
Member

@MartinNowack Thanks for confirmation!

@skanav
Copy link
Contributor Author

skanav commented Nov 2, 2020

@PhilippWendler do we need something more here?

@PhilippWendler
Copy link
Member

I had just hoped that we get some response for sosy-lab/sv-benchmarks#1125, but as discussed let's merge it now.

@PhilippWendler PhilippWendler merged commit 033debc into master Nov 3, 2020
@PhilippWendler PhilippWendler deleted the TI-update-to-BaseTool2-verifiers branch November 3, 2020 08:44
@PhilippWendler
Copy link
Member

@skanav I just noticed that this broke some other tool-info modules that inherit from modules changes in this PR. At least JBMC is affected. Would it be possible for you to have a look at which tool-info modules inherit from the ones changed here and adjust them (this should typically be small changes only)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants