-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update several tool-info modules to BaseTool2 #646
Conversation
Should I update the Ultimate tools? How soon is it needed? |
This would be great.
It would be needed for the preruns. So it should be done soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have a few comments that I added. Many of these actually apply to more than one tool-info module but I always added them in only one location, so please check for each comment in which tool-info modules it also applies.
Just remembered sosy-lab/sv-benchmarks#1125, I think it would make sense to wait for a resolution of that issue before merging this PR. |
131b44a
to
6f11a4c
Compare
Didn't seem like there is active work on sosy-lab/sv-benchmarks#1125, but I actually depend on this PR (doesn't the whole competition infrastructure need this?), so I would welcome if this could get merged quickly. |
From my side, changes for KLEE look good. |
@MartinNowack Thanks for confirmation! |
@PhilippWendler do we need something more here? |
I had just hoped that we get some response for sosy-lab/sv-benchmarks#1125, but as discussed let's merge it now. |
@skanav I just noticed that this broke some other tool-info modules that inherit from modules changes in this PR. At least JBMC is affected. Would it be possible for you to have a look at which tool-info modules inherit from the ones changed here and adjust them (this should typically be small changes only)? |
updated tool info modules of verification (and validation) tools from sv-comp 20 to start using data models from the task dict.
this is required for the competition after PR 169 in benchmark definitions repo is merged
The following are still remaining: