Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code improve] No more views passing around #1159

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[code improve] No more views passing around #1159

merged 2 commits into from
Jan 13, 2025

Conversation

Liyw979
Copy link
Contributor

@Liyw979 Liyw979 commented Jan 12, 2025 •
edited
Loading

We can access the current view object using this.view, no need to pass it around the call graph algorithms.

SootUp/sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java

Lines 62 to 64 in 76f7e78

protected AbstractCallGraphAlgorithm(@Nonnull View view) {
this.view = view;
}

swissiety
swissiety approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense - thx!

@swissiety swissiety merged commit 5f1b50b into soot-oss:develop Jan 13, 2025
7 checks passed
@Liyw979 Liyw979 deleted the improve/delete_view branch January 14, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissiety swissiety swissiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liyw979 @swissiety