-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy compatible dot funciton and override __matmul__ operator #899
Open
YukioOobuchi
wants to merge
1
commit into
master
Choose a base branch
from
feature/20210328-dot-matmul-op
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
# Copyright (c) 2021 Sony Corporation. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import numpy as np | ||
|
||
|
||
def dot(a, b, out=None): | ||
''' | ||
A compatible operation with ``numpy.dot``. | ||
|
||
Note: | ||
Any operation between nnabla's Variable/NdArray and numpy array is not supported. | ||
|
||
Args: | ||
a (Variable, NdArray or scalar): Left input array. | ||
b (Variable, NdArray or scalar): Right input array. | ||
out: Not supported so far. | ||
|
||
Returns: | ||
~nnabla.Variable: N-D array. | ||
|
||
''' | ||
import nnabla as nn | ||
import nnabla.fucntions as F | ||
assert out is None, "The `out` option is not supported." | ||
|
||
def _chk(x): | ||
return isinstance(x, (nn.NdArray, nn.Variable)) | ||
|
||
if _chk(a) and _chk(b): | ||
if a.ndim == 1 and b.ndim == 1: | ||
return return F.sum(a * b) | ||
if a.ndim == 2 and b.ndim >= 2: | ||
return F.affine(a, b) | ||
if a.ndim == 0 or b.ndim == 0: | ||
return a * b | ||
if a.ndim > 2 and b.ndim == 1: | ||
h = F.affine(x, F.reshape(y, (-1, 1)), base_axis=x.ndim - 1) | ||
return F.reshape(h, h.shape[:-1]) | ||
raise ValueError(f'Undefined configuration: a.ndim={a.ndim}, b.ndim:{b.ndim}') | ||
|
||
return x * y | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be a runtime error. Function inputs are |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider making this a descriptive name, such as
_is_nnabla_data_type
.