Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github actions error #132

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sbsekiguchi
Copy link
Contributor

This PR is for fixing the following github actions errros.

black error

The error is caused by black installation.
From version 24.10.0, black dropped python3.8 supports.

To solve this, I used python 3.9 in build.yaml

mypy error

With the new version of mypy, the test for typing fails.

The solution is to use 0.0 not 0 in v_function_model_trainer.

The error message is

nnabla_rl/model_trainers/v_value/v_function_trainer.py:127: error: Incompatible types in assignment (expression has type "Union[float, Any]", variable has type "int")  [assignment]

Copy link
Contributor

@ishihara-y ishihara-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishihara-y ishihara-y merged commit 8155185 into master Nov 5, 2024
11 checks passed
@ishihara-y ishihara-y deleted the feature/20241028-fix-github-actions-error branch November 5, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants