Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for MEMORY_STATISTICS table in schema #898

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Arham-Nasir
Copy link

define table in common/schema.h file of sonic-swss-common

@Arham-Nasir Arham-Nasir changed the title Define MEMORY_STATISTICS_Table in sonic-swss-common Adding MEMORY_STATISTICS_Table Sep 20, 2024
@FengPan-Frank
Copy link
Contributor

LGTM, pls resolve the conflicts.

@Arham-Nasir
Copy link
Author

LGTM, pls resolve the conflicts.

@FengPan-Frank , thank you for the review! I checked again. Please let me know if you need any further information.

@Arham-Nasir Arham-Nasir changed the title Adding MEMORY_STATISTICS_Table Add definition for MEMORY_STATISTICS table in schema Oct 23, 2024
@Arham-Nasir
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ridahanif96
Copy link

@xincunli-sonic @qiluo-msft @zbud-msft pls help review this PR. All swsscommon/db changes are getting failed since this PR in not Part of master

Copy link

@ridahanif96 ridahanif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me , please wait till all checks passes and merge this PR!

@ridahanif96
Copy link

Hi @FengPan-Frank , can you please help merge this PR or get it merged with help of authorized person

@FengPan-Frank
Copy link
Contributor

Hi @FengPan-Frank , can you please help merge this PR or get it merged with help of authorized person

I don't have merge permission, either. pls check with qiluo-msft

@ridahanif96
Copy link

@qiluo-msft can you please help review this feature and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants