Add bulk meter stats fetch support in syncd #1460
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshmv
force-pushed
the
dash_meter_fetch
branch
from
a79fdcf
to
b6f6ab1
Compare
This PR adds syncd FlexCounter support to periodically fetch SAI bulk stats for Dash meter buckets and write the stats to COUNTERS_DB. Multiple Meter buckets, each with inbound and outbound byte counters, are internally allocated for each ENI object in the Dash pipeline. To support this a new DashMeterCounterContext class is derived from BaseCounterContext that tracks and invokes SAI bulkGetStats for all the meter bucket objects for each ENI object added to the context. Reference - https://github.com/sonic-net/DASH/blob/main/documentation/metering/metering.md Signed-off-by: Mukesh MV <[email protected]>
mukeshmv
force-pushed
the
dash_meter_fetch
branch
from
b6f6ab1
to
ef21445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syncd FlexCounter support to periodically fetch SAI bulk stats for Dash meter buckets and write the stats to COUNTERS_DB.
Multiple Meter buckets, each with inbound and outbound byte counters, are internally allocated for each ENI object in the Dash pipeline.
To support this a new DashMeterCounterContext class is derived from BaseCounterContext that tracks and invokes SAI bulkGetStats for all the meter bucket objects for each ENI object added to the context.
Reference -
https://github.com/sonic-net/DASH/blob/main/documentation/metering/metering.md
COUNTERS_DB -
Key:
"COUNTERS:{eni_id:oid:0x7008000000001,meter_class:1000,switch_id:oid:0x0}"Field-Value pairs: