Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco|express-boot]: Add support for cisco express boot in syncd #1329

Merged
merged 5 commits into from
Dec 12, 2023
Merged

[cisco|express-boot]: Add support for cisco express boot in syncd #1329

merged 5 commits into from
Dec 12, 2023

Conversation

jhli-cisco
Copy link
Contributor

@jhli-cisco jhli-cisco commented Nov 30, 2023

Add support of express boot for cisco 8000 platform. There are 4 PRs for this feature:

sonic-net/sonic-buildimage#17369
#1329
sonic-net/sonic-utilities#3056
sonic-net/sonic-host-services#90

Copy link
Collaborator

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments, and make all checks success with build and add unittests for thise

syncd/CommandLineOptions.h Outdated Show resolved Hide resolved
syncd/RequestShutdownCommandLineOptions.cpp Show resolved Hide resolved
syncd/RequestShutdownCommandLineOptions.h Outdated Show resolved Hide resolved
syncd/Syncd.cpp Show resolved Hide resolved
syncd/Syncd.cpp Show resolved Hide resolved
@jhli-cisco
Copy link
Contributor Author

please address comments, and make all checks success with build and add unittests for thise

Please check my reply to comments in line. Modified the ut test case . It is now passing. The latest swss build pipeline failure doesn't seem to be related with this changeset. Will ask to rerun.

@Pterosaur
Copy link
Contributor

/azpw run Azure.sonic-sairedis

@jhli-cisco
Copy link
Contributor Author

@kcudnik Thank you very much for approving it. I am wondering if you are able to merge? Who shall I contact to get it merged if you can't?

@kcudnik kcudnik merged commit 641b730 into sonic-net:master Dec 12, 2023
14 checks passed
@jhli-cisco jhli-cisco deleted the jhli-exb branch December 12, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants