Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate PFC storm using PFC backpressure on Arista DCS-7060X6 devices #15594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veronica-arista
Copy link
Contributor

Description of PR

Add a pfc_gen script for Arista DCS-7060X6 fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista DCS-7060X6 fanout devices running EOS.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Adds more reliable PFC storm generation for interfaces connected to Arista DCS-7060X6 fanout devices

How did you do it?

How did you verify/test it?

Ran the pfcwd tests on t1 switch with interfaces connected to Arista DCS-7060X6 device, ensured the new script was used and pfc storm was appropriately detected.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Add a pfc_gen script that generates storm by directly setting PFC
backpressure status in hardware (using broadcom shell commands) and
modify pfc_storm to use this new script if the port is connected to th5
MPC. Intended to upstream for MSFT.
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/common/helpers/pfc_gen_th5.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/helpers/pfc_gen_th5.py:7:1: F401 'binascii' imported but unused
tests/common/helpers/pfc_gen_th5.py:59:31: F541 f-string is missing placeholders
tests/common/helpers/pfc_gen_th5.py:62:52: W605 invalid escape sequence 'S'
tests/common/helpers/pfc_gen_th5.py:62:67: W605 invalid escape sequence '['
tests/common/helpers/pfc_gen_th5.py:62:75: W605 invalid escape sequence 'd'
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants