Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check pg_profile_lookup.ini in multiasic specific path. #15578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rraghav-cisco
Copy link
Contributor

Description of PR

Summary:
tests/qos/test_buffers.py is failing in mAsic platforms since the pg_profile_lookup.ini path

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

The script: qos/test_buffers.py is using wrong path for multi-asic platforms. It gives this error:

        if (res.is_failed or 'exception' in res) and not module_ignore_errors:
>           raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E           tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E           {"changed": true, "cmd": "cat /usr/share/sonic/device/x86_64-8800_rp-r0/Cisco-8800-RP//pg_profile_lookup.ini", "delta": "0:00:00.006060", "end": "2024-10-31 14:58:57.717623", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2024-10-31 14:58:57.711563", "stderr": "cat: /usr/share/sonic/device/x86_64-8800_rp-r0/Cisco-8800-RP//pg_profile_lookup.ini: No such file or directory", "stderr_lines": ["cat: /usr/share/sonic/device/x86_64-8800_rp-r0/Cisco-8800-RP//pg_profile_lookup.ini: No such file or directory"], "stdout": "", "stdout_lines": []}

How did you do it?

Updated the script to use asic-specific path for this file.

How did you verify/test it?

Ran it on my TB. For cisco-8000 this script skips:

--------------------------------------------------------------------------- generated xml file: /run_logs/buffer/2024-11-15-01-17-03/pfcwd/qos/test_buffer_2024-11-15-01-17-03.xml ---------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------- live log sessionfinish -------------------------------------------------------------------------------------------------------------------
01:30:05 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
================================================================================================================== short test summary info ===================================================================================================================
SKIPPED [17] qos/test_buffer.py: These tests don't apply to cisco 8000 platforms or T2 or m0/mx, since they support only traditional model.
SKIPPED [1] qos/test_buffer.py:2390: These tests don't apply to cisco 8000 platforms or T2 or m0/mx, since they support only traditional model.
SKIPPED [1] qos/test_buffer.py:400: Skip test in traditional model
========================================================================================================= 19 skipped, 1 warning in 780.02s (0:13:00) =========================================================================================================
DEBUG:tests.conftest:[log_custom_msg] item: <Function test_buffer_deployment[xx37-lc7]>

@rraghav-cisco
Copy link
Contributor Author

@sdszhang , @auspham : Pls let me know whey azp run failed.

@auspham
Copy link
Contributor

auspham commented Nov 15, 2024

@rraghav-cisco it's just our CI issue. I'll retrigger for you

@rraghav-cisco
Copy link
Contributor Author

@abdosi : for viz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants