[active-active] Fix extra toggle after default route N/A #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
yxieca
approved these changes
Nov 12, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Nov 13, 2024
Approach What is the motivation for this PR? Fixes sonic-net#278 Fix the extra toggle after the default route N/A. (active, active, up), ok <- default route n/a -> toggle to standby (active, standby, up), n/a <- mux probe active from the periodically probe (active, active, up), n/a <- mux state standby returned from the toggle to standby (active, standby, up), n/a -> toggle to active (active, active, up), n/a <- mux state active returned from the toggle to active (active, active, up), n/a <- link prober unknown (unknown, active, up), n/a -> toggle to standby (unknown, standby, up), n/a <- mux state standby returned from toggle to standby Signed-off-by: Longxiang Lyu [email protected] Work item tracking Microsoft ADO (number only): 30186968 How did you do it? Let's check the default route state when the mux transits into (active, standby, up), if the default route state is N/A, skip the toggle to active. How did you verify/test it? UT
|
Cherry-pick PR to 202405: #280 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 13, 2024
Approach What is the motivation for this PR? Fixes #278 Fix the extra toggle after the default route N/A. (active, active, up), ok <- default route n/a -> toggle to standby (active, standby, up), n/a <- mux probe active from the periodically probe (active, active, up), n/a <- mux state standby returned from the toggle to standby (active, standby, up), n/a -> toggle to active (active, active, up), n/a <- mux state active returned from the toggle to active (active, active, up), n/a <- link prober unknown (unknown, active, up), n/a -> toggle to standby (unknown, standby, up), n/a <- mux state standby returned from toggle to standby Signed-off-by: Longxiang Lyu [email protected] Work item tracking Microsoft ADO (number only): 30186968 How did you do it? Let's check the default route state when the mux transits into (active, standby, up), if the default route state is N/A, skip the toggle to active. How did you verify/test it? UT
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Fixes #278
Fix the extra toggle after the default route
N/A.Signed-off-by: Longxiang Lyu [email protected]
Work item tracking
How did you do it?
Let's check the default route state when the mux transits into
(active, standby, up), if the default route state isN/A, skip the toggle to active.How did you verify/test it?
UT
Any platform specific information?
Documentation