-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeQL] fix unmet build dependency #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
approved these changes
Nov 10, 2023
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
Dec 18, 2023
Summary: Fixes # (issue) Fix unmet build dependencies. sign-off: Jing Zhang [email protected]
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
Dec 19, 2023
This reverts commit 0ed5026.
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Jan 18, 2024
Summary: Fixes # (issue) Fix unmet build dependencies. sign-off: Jing Zhang [email protected]
Cherry-pick PR to 202305: #236 |
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Jan 18, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
Summary: Fixes # (issue) Fix unmet build dependencies. sign-off: Jing Zhang [email protected]
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Jan 25, 2024
Summary: Fixes # (issue) Fix unmet build dependencies. sign-off: Jing Zhang [email protected]
Cherry-pick PR to 202205: #241 |
1 similar comment
Issue should be resolved by #231. 202205 branch does not need this PR any more. |
1 similar comment
@zjswhhh please add ADO number to this PR and work on a 202311 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Fix unmet build dependencies.
sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
Work item tracking
How did you do it?
How did you verify/test it?
Any platform specific information?
Documentation