Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQL] fix unmet build dependency #222

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Nov 10, 2023

Description of PR

Summary:
Fixes # (issue)
Fix unmet build dependencies.

sign-off: Jing Zhang [email protected]

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

Work item tracking
  • Microsoft ADO (number only):

How did you do it?

How did you verify/test it?

Any platform specific information?

Documentation

@zjswhhh zjswhhh changed the title [codeql] DO NOT REVIEW [CodeQL] fix unmet build dependency Nov 10, 2023
@zjswhhh zjswhhh marked this pull request as ready for review November 10, 2023 19:06
@zjswhhh zjswhhh merged commit 10b7c0b into sonic-net:master Nov 10, 2023
9 checks passed
@zjswhhh zjswhhh deleted the codeql_master branch November 10, 2023 19:33
zjswhhh added a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Dec 18, 2023
Summary:
Fixes # (issue)
Fix unmet build dependencies.

sign-off: Jing Zhang [email protected]
zjswhhh added a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Dec 19, 2023
mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Jan 18, 2024
Summary:
Fixes # (issue)
Fix unmet build dependencies.

sign-off: Jing Zhang [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #236

mssonicbld pushed a commit that referenced this pull request Jan 18, 2024
Summary:
Fixes # (issue)
Fix unmet build dependencies.

sign-off: Jing Zhang [email protected]
mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Jan 25, 2024
Summary:
Fixes # (issue)
Fix unmet build dependencies.

sign-off: Jing Zhang [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #241

@mssonicbld
Copy link
Collaborator

@zjswhhh cherry pick PR didn't pass PR checker. Please check!!!
#241

1 similar comment
@mssonicbld
Copy link
Collaborator

@zjswhhh cherry pick PR didn't pass PR checker. Please check!!!
#241

@zjswhhh
Copy link
Contributor Author

zjswhhh commented Jan 30, 2024

Issue should be resolved by #231.

202205 branch does not need this PR any more.

@mssonicbld
Copy link
Collaborator

@zjswhhh cherry pick PR didn't pass PR checker. Please check!!!
#241

1 similar comment
@mssonicbld
Copy link
Collaborator

@zjswhhh cherry pick PR didn't pass PR checker. Please check!!!
#241

@yxieca
Copy link
Contributor

yxieca commented Feb 16, 2024

@zjswhhh please add ADO number to this PR and work on a 202311 PR.

@zjswhhh
Copy link
Contributor Author

zjswhhh commented Feb 20, 2024

@zjswhhh please add ADO number to this PR and work on a 202311 PR.

Hi @yxieca - this commit is already in 202311 (PR was merged before the cut date).

@yxieca
Copy link
Contributor

yxieca commented Feb 21, 2024

@zjswhhh please add ADO number to this PR and work on a 202311 PR.

Hi @yxieca - this commit is already in 202311 (PR was merged before the cut date).

@zjswhhh please add ADO number as it went back to earlier branches. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants