Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warmboot] config all interfaces back to auto if reconciliation times out #220

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Sep 20, 2023

Description of PR

Summary:
Fixes # (issue)

This PR is to fix a warmboot bug that when linkmgrd reconciliation times out, some interfaces are left in manual mode.

sign-off: Jing Zhang [email protected]

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

To make sure all interfaces have correct muxcable config.

Work item tracking
  • Microsoft ADO (number only):
    24911432

How did you do it?

Run cli when timeout handler is called.

How did you verify/test it?

  1. Ran warmboot with healthy dualtor DUT.
  2. Ran warmboot with unhealthy dualtor DUT.

Both cases passed.

Any platform specific information?

Documentation

src/MuxManager.cpp Outdated Show resolved Hide resolved
src/MuxManager.cpp Outdated Show resolved Hide resolved
@zjswhhh zjswhhh requested a review from vaibhavhd October 2, 2023 18:27
src/MuxManager.cpp Outdated Show resolved Hide resolved
src/MuxManager.cpp Outdated Show resolved Hide resolved
@zjswhhh zjswhhh requested a review from vaibhavhd October 3, 2023 20:15
@zjswhhh zjswhhh merged commit f34cb09 into sonic-net:master Oct 4, 2023
8 checks passed
@zjswhhh zjswhhh deleted the wr_master branch October 4, 2023 18:47
@zjswhhh zjswhhh restored the wr_master branch October 4, 2023 18:47
@zjswhhh zjswhhh deleted the wr_master branch October 4, 2023 18:48
@zjswhhh zjswhhh restored the wr_master branch October 4, 2023 18:48
@zjswhhh zjswhhh deleted the wr_master branch October 4, 2023 18:48
yxieca pushed a commit that referenced this pull request Oct 11, 2023
…es out (#220)

Description of PR
Summary:
Fixes # (issue)

This PR is to fix a warmboot bug that when linkmgrd reconciliation times out, some interfaces are left in manual mode.

sign-off: Jing Zhang [email protected]
yxieca pushed a commit that referenced this pull request Oct 11, 2023
…es out (#220)

Description of PR
Summary:
Fixes # (issue)

This PR is to fix a warmboot bug that when linkmgrd reconciliation times out, some interfaces are left in manual mode.

sign-off: Jing Zhang [email protected]
StormLiangMS pushed a commit that referenced this pull request Oct 17, 2023
…es out (#220)

Description of PR
Summary:
Fixes # (issue)

This PR is to fix a warmboot bug that when linkmgrd reconciliation times out, some interfaces are left in manual mode.

sign-off: Jing Zhang [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants