[active-standby] Fix extra toggle observed in config reload
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
fix_extra_toggle_standby_config_reload
branch
from
9cf11dd
to
f671b7d
Compare
Signed-off-by: Longxiang Lyu <[email protected]>
Signed-off-by: Longxiang Lyu <[email protected]>
Signed-off-by: Longxiang Lyu <[email protected]>
Signed-off-by: Longxiang Lyu <[email protected]>
zjswhhh
reviewed
Aug 9, 2023
yxieca
approved these changes
Aug 11, 2023
zjswhhh
approved these changes
Aug 11, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 14, 2023
Approach What is the motivation for this PR? Fix the issue that an extra mux toggle is observed when the standby ToR does a config reload. Two reasons: 1. extra toggle due to link prober init to unknown when the mux is wait The state transitions are: (unknown, standby, down) -- activate state machine --> (standby, standby, down) --> link prober unknown --> (unknown, standby, down) --> enter mux wait and probe mux --> (unknown, wait, down) --> port up --> (unknown, wait, up) --> mux probe standby --> (unknown, standby, up) --> toggle to active 2. extra toggle due to the port up event arriving within the link prober unknown detection period Signed-off-by: Longxiang Lyu [email protected] Work item tracking Microsoft ADO (number only): 24794476 How did you do it? when the port up and init the link prober state, init the link prober state to wait when the mux state is wait reset the link prober state when port up to refresh the detection. How did you verify/test it? UT
yxieca
pushed a commit
that referenced
this pull request
Sep 6, 2023
Approach What is the motivation for this PR? Fix the issue that an extra mux toggle is observed when the standby ToR does a config reload. Two reasons: 1. extra toggle due to link prober init to unknown when the mux is wait The state transitions are: (unknown, standby, down) -- activate state machine --> (standby, standby, down) --> link prober unknown --> (unknown, standby, down) --> enter mux wait and probe mux --> (unknown, wait, down) --> port up --> (unknown, wait, up) --> mux probe standby --> (unknown, standby, up) --> toggle to active 2. extra toggle due to the port up event arriving within the link prober unknown detection period Signed-off-by: Longxiang Lyu [email protected] Work item tracking Microsoft ADO (number only): 24794476 How did you do it? when the port up and init the link prober state, init the link prober state to wait when the mux state is wait reset the link prober state when port up to refresh the detection. How did you verify/test it? UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #217
Type of change
Approach
What is the motivation for this PR?
Fix the issue that an extra mux toggle is observed when the standby ToR does a config reload.
Two reasons:
extra toggle due to link prober init to
unknownwhen the mux iswaitThe state transitions are:
(
unknown,standby,down) -- activate state machine -->(
standby,standby,down) --> link proberunknown-->(
unknown,standby,down) --> enter muxwaitand probe mux -->(
unknown,wait,down) --> portup-->(
unknown,wait,up) --> mux probestandby-->(
unknown,standby,up) --> toggle to activeextra toggle due to the port
upevent arriving within the link proberunknowndetection periodSigned-off-by: Longxiang Lyu [email protected]
Work item tracking
How did you do it?
upand init the link prober state, init the link prober state towaitwhen the mux state iswaitupto refresh the detection.How did you verify/test it?
UT
Any platform specific information?
Documentation