Adding support for persistent storage and retrieval of DPU reboot-cause #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/process-reboot-cause
Outdated
| @@ -69,6 +70,45 @@ def read_reboot_cause_files_and_save_state_db(): | |||
| x = TIME_SORTED_FULL_REBOOT_FILE_LIST[i] | |||
| os.remove(x) | |||
|
|
|||
| def read_dpu_reboot_cause_files_and_save_chassis_state_db(): | |||
| # Get platform using device_info.get_platform() | |||
| platform_info = device_info.get_platform_info() | |||
There was a problem hiding this comment.
The code to query DPUs from the platform.json should be part of src/sonic-py-common/sonic_py_common/device_info.py. There is an implementation for getting the get_num_dpus, so we can put something like get_dpus_info. This will prevent a code duplication in all places that need to access DPUs information
|
|
||
| # Assert that makedirs was called for the DPU directories | ||
| mock_makedirs.assert_any_call(os.path.join('/host/reboot-cause/module', 'dpu0')) | ||
| mock_makedirs.assert_any_call(os.path.join('/host/reboot-cause/module', 'dpu1')) |
There was a problem hiding this comment.
read_dpu_reboot_cause_files_and_save_chassis_state_d is not covered by the tests. Please new test for it.
hardware implementation requirements
rameshraghupathy
force-pushed
the
master
branch
from
466b70d
to
17345aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for persistent storage and retrieval of DPU reboot-cause