-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build issues caused due to inaccessible mirror URLs #20783
base: 202111
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, image builds and loads with these changes.
DEFAULT_MIRROR_URLS=http://debian-archive.trafficmanager.net/debian/,http://packages.trafficmanager.net/debian/debian/ | ||
DEFAULT_MIRROR_SECURITY_URLS=http://debian-archive.trafficmanager.net/debian-security/,http://packages.trafficmanager.net/debian/debian-security/ | ||
DEFAULT_MIRROR_URLS=http://debian-archive.trafficmanager.net/debian/ | ||
DEFAULT_MIRROR_SECURITY_URLS=http://debian-archive.trafficmanager.net/debian-security/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, image builds and loads after making these changes.
@liushilongbuaa @xumia is this expected? This impacts all branches. |
It is deprecated. Maybe cherry pick PR17113 will help. |
@nmoray , can you cherry pick that PR and test locally to confirm? |
@liushilongbuaa Yeah, I tested that already. It still fails for one of the debian packages during the "make configure" itself. My changes are sort of back porting of PR17113 only. I have just added following piece of code to avoid further build failures.
|
Yes @liushilongbuaa these changes are required as "http://packages.trafficmanager.net" URL is no more valid / accessible. You can quickly check that by building the latest 202111 branch. Note: Make sure sonic-slave-buster will be rebuilt. |
Maybe here is missing commit list.
|
Pipeline reports error: |
@liushilongbuaa Sorry, what needs to be done here? |
All these commits are using "http://packages.trafficmanager.net/" URL which is no more accessible. :-) |
I mean all branches after 202205 are using snapshot mirror. 202111 didn't pick the changes. |
Why I did it
Fixed build issues caused due to inaccessible mirror URLs
Failure logs:
How I did it
Updated build_mirror_config.sh script with the public debians storage links
How to verify it
Run "make configure" and try to build the buster and bullseye debian packages
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
UT logs:
Description for the changelog
Fixed build issues caused due to inaccessible mirror URLs