Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build issues caused due to inaccessible mirror URLs #20783

Open
wants to merge 1 commit into
base: 202111
Choose a base branch
from

Conversation

nmoray
Copy link
Contributor

@nmoray nmoray commented Nov 13, 2024

Why I did it

Fixed build issues caused due to inaccessible mirror URLs

Failure logs:

0.323 Err:1 http://packages.trafficmanager.net/debian/debian buster InRelease                                                                                                                         
0.323   400  The account being accessed does not support http. [IP: 13.107.246.69 80]                                                                                                                 
0.341 Get:2 http://debian-archive.trafficmanager.net/debian buster InRelease [122 kB]                                                                                                                 
0.357 Err:3 http://packages.trafficmanager.net/debian/debian buster-updates InRelease                                                                                                                 
0.357   400  The account being accessed does not support http. [IP: 13.107.246.69 80]                                                                                                                 
0.390 Err:4 http://packages.trafficmanager.net/debian/debian buster-backports InRelease                                                                                                               
0.390   400  The account being accessed does not support http. [IP: 13.107.246.69 80]                                                                                                                 
0.423 Err:5 http://packages.trafficmanager.net/debian/debian-security buster_updates InRelease                                                                                                        
0.423   400  The account being accessed does not support http. [IP: 13.107.246.69 80]                                                                                                                 
0.435 Get:6 http://debian-archive.trafficmanager.net/debian buster-updates InRelease [56.6 kB]                                                                                                        
0.460 Ign:7 http://debian-archive.trafficmanager.net/debian buster-backports InRelease                                                                                                                
0.484 Get:8 http://debian-archive.trafficmanager.net/debian-security buster/updates InRelease [34.8 kB]                                                                                               
0.509 Err:9 http://debian-archive.trafficmanager.net/debian buster-backports Release                                                                                                                  
0.509   404  Not Found [IP: 172.179.119.208 80]                                                     

How I did it

Updated build_mirror_config.sh script with the public debians storage links

How to verify it

Run "make configure" and try to build the buster and bullseye debian packages

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

UT logs:

sonic: docker images | grep "sonic-slave-buster"
sonic-slave-buster-nikhil                       76ee36d5772           90de8c3acf01   6 minutes ago    5.11GB
sonic-slave-buster                              72c2aad2758           8f7ee816c3a6   7 minutes ago    5.11GB

Description for the changelog

Fixed build issues caused due to inaccessible mirror URLs

Copy link

@mkprasannaGH mkprasannaGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, image builds and loads with these changes.

DEFAULT_MIRROR_URLS=http://debian-archive.trafficmanager.net/debian/,http://packages.trafficmanager.net/debian/debian/
DEFAULT_MIRROR_SECURITY_URLS=http://debian-archive.trafficmanager.net/debian-security/,http://packages.trafficmanager.net/debian/debian-security/
DEFAULT_MIRROR_URLS=http://debian-archive.trafficmanager.net/debian/
DEFAULT_MIRROR_SECURITY_URLS=http://debian-archive.trafficmanager.net/debian-security/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, image builds and loads after making these changes.

@saiarcot895
Copy link
Contributor

@liushilongbuaa @xumia is this expected? This impacts all branches.

@liushilongbuaa
Copy link
Contributor

It is deprecated. Maybe cherry pick PR17113 will help.

@liushilongbuaa
Copy link
Contributor

@nmoray , can you cherry pick that PR and test locally to confirm?

@nmoray
Copy link
Contributor Author

nmoray commented Nov 14, 2024

@nmoray , can you cherry pick that PR and test locally to confirm?

@liushilongbuaa Yeah, I tested that already. It still fails for one of the debian packages during the "make configure" itself. My changes are sort of back porting of PR17113 only. I have just added following piece of code to avoid further build failures.

if [ "$DISTRIBUTION" == "buster" ]; then
   DEFAULT_MIRROR_URLS=http://archive.debian.org/debian/
fi

@nmoray
Copy link
Contributor Author

nmoray commented Nov 14, 2024

@liushilongbuaa @xumia is this expected? This impacts all branches.

Yes @liushilongbuaa these changes are required as "http://packages.trafficmanager.net" URL is no more valid / accessible. You can quickly check that by building the latest 202111 branch.

Note: Make sure sonic-slave-buster will be rebuilt.

@liushilongbuaa
Copy link
Contributor

Maybe here is missing commit list.

e9e04e191c Use the archive repo for Buster (#18678)
6d75f80856 [Build] Change the default mirror version config file (#13786) (#13903)
c9806ec3c3 [Build][202211] Support Debian snapshot mirror to improve build stability (#13371) (#13382)
8395de69d3 [Build] Support j2 template for debian sources (#12557) (#13185)

@liushilongbuaa
Copy link
Contributor

Pipeline reports error:
"The pipeline is not valid. Could not find a pool with name sonictest-t1-lag. The pool does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz."
@wangxin FYI.

@nmoray
Copy link
Contributor Author

nmoray commented Nov 14, 2024

Pipeline reports error: "The pipeline is not valid. Could not find a pool with name sonictest-t1-lag. The pool does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz." @wangxin FYI.

@liushilongbuaa Sorry, what needs to be done here?

@nmoray
Copy link
Contributor Author

nmoray commented Nov 14, 2024

Maybe here is missing commit list.

e9e04e191c Use the archive repo for Buster (#18678)
6d75f80856 [Build] Change the default mirror version config file (#13786) (#13903)
c9806ec3c3 [Build][202211] Support Debian snapshot mirror to improve build stability (#13371) (#13382)
8395de69d3 [Build] Support j2 template for debian sources (#12557) (#13185)

All these commits are using "http://packages.trafficmanager.net/" URL which is no more accessible. :-)

@liushilongbuaa
Copy link
Contributor

Maybe here is missing commit list.

e9e04e191c Use the archive repo for Buster (#18678)
6d75f80856 [Build] Change the default mirror version config file (#13786) (#13903)
c9806ec3c3 [Build][202211] Support Debian snapshot mirror to improve build stability (#13371) (#13382)
8395de69d3 [Build] Support j2 template for debian sources (#12557) (#13185)

All these commits are using "http://packages.trafficmanager.net/" URL which is no more accessible. :-)

I mean all branches after 202205 are using snapshot mirror. 202111 didn't pick the changes.
Cherry pick these commits maybe help to fix the error. Can you pick these commits and test locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants