Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marvell] platform renaming for innovium and marvell #19829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krismarvell
Copy link
Contributor

@krismarvell krismarvell commented Aug 6, 2024

Why I did it

Renaming of platforms and asic types for marvell
This PR has dependencies on the below submodule PRs

Repo PR title State
sonic-swss [Marvell] platform renaming for innovium Open
sonic-utilities platform renaming for innovium Open
sonic-sairedis [Marvell] platform renaming for innovium Open
sonic-mgmt Changes to support chip name change from innovium to marvell-teralynx Open
sonic-mgmt Changes to support asic name change from marvell to marvell-prestera Open

How I did it

renamed platform folder names and asic types as below
platform/innovium renamed to platform/marvell-teralynx
platform/marvell renamed to platform/marvell-prestera
Above changes are organised into two commits for clarity.

How to verify

Verify marvell-teralynx and marvell-prestera builds going through, and verify the images in respective platform switches and verified linkup of interfaces

Work item tracking
  • Microsoft ADO (number only):

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

master

Description for the changelog

NA

Link to config_db schema for YANG module changes

NA

A picture of a cute animal (not mandatory but encouraged)

@krismarvell krismarvell marked this pull request as draft August 6, 2024 01:28
@krismarvell krismarvell force-pushed the innovium_rename branch 4 times, most recently from af0c1c4 to ed35536 Compare August 12, 2024 07:19
@krismarvell krismarvell marked this pull request as ready for review August 29, 2024 05:26
@krismarvell
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@krismarvell
Copy link
Contributor Author

/azpw ms_conflict

@saiarcot895
Copy link
Contributor

@Blueve please help with the review for this

@liushilongbuaa @xumia please help with the changes to the pipeline yml files. Specifically, are there any other changes needed for the nightly official builds?

@krismarvell
Copy link
Contributor Author

@liushilongbuaa @xumia Can you pls checking if there are additional changes needed for the nightly pipeline builds with these changes ? @Blueve Can you pls help review ?

@liushilongbuaa
Copy link
Contributor

checking.

@saiarcot895
Copy link
Contributor

Would it be possible to keep the image name for marvell_prestera_arm64 and marvell_prestera_armhf the same as it is now? The platform string can be renamed, but if the image name is kept the same, that would be good for scripts/automation that use the existing name.

@krismarvell
Copy link
Contributor Author

krismarvell commented Oct 16, 2024

@saiarcot895 it will be difficult to make the image name same as before due to two below reasons.

  1. the image names are closely tied with ONE_IMAGE definition in marvell platform and hence keeping the old image names vs platform string renames in code may end up in image build errors and may require unclean fix for the same.
  2. Also, for the platform users, we would like to add prestera as reference marker for this asic for clarity.
    The scripts/automation using the above platform image names, is that something i can make appropriate changes so as to work with this change ? Pls let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants