[Local-users-passwords-reset] Add new feature including config, yang and tests #18874
+323
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmy98
force-pushed
the
dev-reset-local-users-password
branch
2 times, most recently
from
d051a6d
to
a9ec9e9
Compare
azmy98
force-pushed
the
dev-reset-local-users-password
branch
5 times, most recently
from
194a5a0
to
5b81bed
Compare
|
|
azmy98
force-pushed
the
dev-reset-local-users-password
branch
14 times, most recently
from
f1f9c87
to
a848ace
Compare
azmy98
force-pushed
the
dev-reset-local-users-password
branch
4 times, most recently
from
432ef6e
to
96119a9
Compare
azmy98
force-pushed
the
dev-reset-local-users-password
branch
8 times, most recently
from
2304076
to
639dc2e
Compare
dgsudharsan
suggested changes
May 14, 2024
platform/mellanox/mlnx-platform-api/sonic_platform/local_users_passwords_reset.py
Outdated
Show resolved
Hide resolved
azmy98
force-pushed
the
dev-reset-local-users-password
branch
2 times, most recently
from
b3077a4
to
4161fc4
Compare
dgsudharsan
approved these changes
May 17, 2024
|
/azpw run Azure.sonic-buildimage |
azmy98
force-pushed
the
dev-reset-local-users-password
branch
2 times, most recently
from
c1689a0
to
320f7bd
Compare
|
/azpw ms_conflict |
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
320f7bd
to
b887b6f
Compare
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
reviewed
Sep 25, 2024
| @@ -2686,6 +2691,11 @@ | |||
| } | |||
| } | |||
| }, | |||
| "LOCAL_USERS_PASSWORDS_RESET": { | |||
There was a problem hiding this comment.
Why this table dupe in config DB?
liuh-80
reviewed
Sep 25, 2024
| description "First Revision"; | ||
| } | ||
|
|
||
| container sonic-local-users-passwords-reset { |
There was a problem hiding this comment.
There is a "FEATURE" table for every feature config, maybe consider using that table?
liuh-80
reviewed
Sep 25, 2024
| $(info "SONIC_BUFFER_MODEL" : "$(SONIC_BUFFER_MODEL)") | ||
| $(info "INSTALL_DEBUG_TOOLS" : "$(INSTALL_DEBUG_TOOLS)") | ||
| $(info "ROUTING_STACK" : "$(SONIC_ROUTING_STACK)") | ||
| $(info "CONFIGURED_PLATFORM" : "$(if $(PLATFORM),$(PLATFORM),$(CONFIGURED_PLATFORM))") |
There was a problem hiding this comment.
Most lines do not require any changes. Can these lines remain unchanged?
maipbui
reviewed
Sep 27, 2024
|
|
||
| try: | ||
| import json | ||
| import subprocess |
There was a problem hiding this comment.
seems these imports are unused
maipbui
reviewed
Sep 27, 2024
| @@ -0,0 +1,63 @@ | |||
| #!/usr/bin/env python | |||
|
|
|||
| import os | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
sonic-net/sonic-platform-common#465
Why I did it
Added local-users-passwords-reset feature-related services according to HLD: sonic-net/SONiC#1577
Work item tracking
Microsoft ADO (number only):
How I did it
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)