[Draft] [dash-flow] Test cases for DASH flow using PTF #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
reviewed
Sep 27, 2024
|
hi @ShaofengWu123 - is this one ready? Thx! |
Hi @KrisNey-MSFT, this PR is not ready because I only finished part of the test cases. Other test cases can only be tested after #608 is merged because they are related to flow actions. Since #608 was merged just a few days ago, I will continue working on unfinished test cases asap. Thx!
Sure, I will update soon. |
|
[like] Kristina Moore reacted to your message:
…________________________________
From: Shaofeng Wu ***@***.***>
Sent: Monday, October 28, 2024 9:30:45 AM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Mention ***@***.***>
Subject: Re: [sonic-net/DASH] [Draft] [dash-flow] Test cases for DASH flow using PTF (PR #621)
hi @ShaofengWu123<https://github.com/ShaofengWu123> - is this one ready? Thx!
Hi @KrisNey-MSFT<https://github.com/KrisNey-MSFT>, this PR is not ready because I only finished part of the test cases. Other test cases can only be tested after #608<#608> is merged because they are related to flow actions. Since #608<#608> was merged just a few days ago, I will continue working on unfinished test cases asap. Thx!
hi Shaofeng, somehow I am seeing the saidashflow.py is empty. is it because this PR is still in draft state? if so, we can make it a real draft. :D
Sure, I will update soon.
—
Reply to this email directly, view it on GitHub<#621 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6HEEYFWPN6RGVFLIETZ5X74LAVCNFSM6AAAAABOYNSOICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGA2DOMJTGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add several functional test cases to verify the dash flow stage. The test cases will utilize PTF framework.