Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DASH-Sonic-HLD] Reference dash-sonic-hld to sonic-net repo #447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DASH-Sonic-HLD] Reference dash-sonic-hld to sonic-net repo #447

wants to merge 2 commits into from
+1 −1,529

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Sep 27, 2023

No description provided.

@GeraldatMicrosoft
Copy link
Collaborator

I approve the request on condition that the DASH repo has a pointer to the HLD. Also, the DASH repo will stay in tact where it sits today as managed by Kristina Moore.

@GeraldatMicrosoft
Copy link
Collaborator

Also, Kristina needs the same permissions in the SONiC repo in order to make updates.

@prsunny
Copy link
Collaborator Author

prsunny commented Sep 28, 2023

Also, Kristina needs the same permissions in the SONiC repo in order to make updates.

Kristina can create PRs for any updates in Sonic repo and it is managed by Linux foundation. For other rights, I suggest to discuss with @zhangyanzhao.

@prsunny
Copy link
Collaborator Author

prsunny commented Sep 28, 2023

I approve the request on condition that the DASH repo has a pointer to the HLD. Also, the DASH repo will stay in tact where it sits today as managed by Kristina Moore.

Ack, thanks @GeraldatMicrosoft. @KrisNey-MSFT , would you signoff this?

@r12f r12f mentioned this pull request Oct 31, 2023
Closed
@r12f r12f self-requested a review October 31, 2023 23:39
@KrisNey-MSFT
Copy link
Collaborator

I approve the request on condition that the DASH repo has a pointer to the HLD. Also, the DASH repo will stay in tact where it sits today as managed by Kristina Moore.

Ack, thanks @GeraldatMicrosoft. @KrisNey-MSFT , would you signoff this?

Leaving document where it is located per 10/2/2023
do-not-merge

@prsunny
Copy link
Collaborator Author

prsunny commented Oct 31, 2023

I approve the request on condition that the DASH repo has a pointer to the HLD. Also, the DASH repo will stay in tact where it sits today as managed by Kristina Moore.

Ack, thanks @GeraldatMicrosoft. @KrisNey-MSFT , would you signoff this?

Leaving document where it is located per 10/2/2023 do-not-merge

@KrisNey-MSFT , the document itself is not removed. Change is to reference to Sonic repo location so that there is only one document to update for community.

@KrisNey-MSFT
Copy link
Collaborator

I approve the request on condition that the DASH repo has a pointer to the HLD. Also, the DASH repo will stay in tact where it sits today as managed by Kristina Moore.

Ack, thanks @GeraldatMicrosoft. @KrisNey-MSFT , would you signoff this?

Leaving document where it is located per 10/2/2023 do-not-merge

@KrisNey-MSFT , the document itself is not removed. Change is to reference to Sonic repo location so that there is only one document to update for community.

-> Will send reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisNey-MSFT KrisNey-MSFT Awaiting requested review from KrisNey-MSFT

@GeraldatMicrosoft GeraldatMicrosoft Awaiting requested review from GeraldatMicrosoft

@gedegrac gedegrac Awaiting requested review from gedegrac

@r12f r12f Awaiting requested review from r12f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prsunny @GeraldatMicrosoft @KrisNey-MSFT @r12f