Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added overlay test plan. #217

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added overlay test plan. #217

wants to merge 5 commits into from

Conversation

aputriax
Copy link
Collaborator

@aputriax aputriax commented Sep 9, 2022 •
edited
Loading

  • Overlay test plan page.
  • ENI detailed test plan.
  • VNET to VNET detailed test plan.

Signed-off-by: Anton Putria [email protected]

@ghost
Copy link

ghost commented Sep 9, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@prsunny
Copy link
Collaborator

prsunny commented Sep 16, 2022

@prabhataravind to review

chrispsommers
chrispsommers reviewed Sep 27, 2022
View reviewed changes
test/docs/testplans/conntrack.md

1. Each test should be executed using TCP and UDP streams.
1. Each test should be executed for Inbound and Outbound routing scenario.
1. So far there is **no direct API to get active connection number** or CPS. Verification might be done using indirect ways:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be brought to the Behavioral Model working group. Perhaps we need to agree on some DASH SAI APIs for "telemetry" type usages (possibly fixed headers, i.e. non-P4-derived)

@KrisNey-MSFT
Copy link
Collaborator

Can we categorize these according to the conversation in Sept 22 meeting (add a column perhaps?):
Test cases can be run but fail?
Test cases cannot be run, Implementation is missing?
Test cases cannot be done as API is missing?
Engine (bmv2 & P4C) does not support the test

@aputriax
Copy link
Collaborator Author

aputriax commented Oct 3, 2022

I'd like to keep test plan separately from the test results.
We can keep this document as is with test steps only, and add test run report against BMv2 as a part of CI. This could be a GitHub action, so every change in pipeline or in tests will issue test run and publish a report. And we will see what does works and what fails. Next, we can think how to link issues.

@chrispsommers
Copy link
Collaborator

Looks like you need to add "reconvergence" to .wordlist.txt, probably picked up the "typo" from a merge from main.

@aputriax
Copy link
Collaborator Author

@prsunny @prabhataravind Could you please to look at this PR?

@aputriax
Copy link
Collaborator Author

aputriax commented Nov 1, 2022

Looks like you need to add "reconvergence" to .wordlist.txt, probably picked up the "typo" from a merge from main.

@chrispsommers This word was already in main. I rebased my branch on the latest main and now it looks good.

@prsunny
Copy link
Collaborator

prsunny commented Jan 6, 2023

@theasianpianist to review/signoff

aputriax and others added 5 commits January 10, 2023 13:07
@aputriax
Added overlay test plan.
f13abf4 
- Overlay test plan page.
- ENI detaild test plan.

Signed-off-by: Anton Putria <[email protected]>
@aputriax
Added VNET-to-VNET test plan.
84c122e 
Signed-off-by: Anton Putria <[email protected]>
@aputriax
Added connection tracking test plan.
e90eb85 
- Added conntrack.md
- Updated existing vnet.md and eni.md
- Added link to the test plans in dash-sonic-hld.md

Signed-off-by: Anton Putria <[email protected]>
@aputriax
Updated overlay test plans.
5f9b6b7 
- Removed one dirrection lookup test based on PR sonic-net#238.
- Added connection tracking tests for the custom ageing timeout.
- Fixed spellcheck errors.

Signed-off-by: Anton Putria <[email protected]>
@aputriax
Dash ptf overlay testplan update with new cases.
c1533cc 
- Updated Connection tracking test plan
- ENI test plan update
- Vnet test plan: listed all new test cases, added tests description
- Updated requirements and underlay routing dependencies.
- Style minor updated

Signed-off-by: Yuriy Harhas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispsommers chrispsommers chrispsommers left review comments

@mgheorghe mgheorghe Awaiting requested review from mgheorghe

@prsunny prsunny Awaiting requested review from prsunny

@Pterosaur Pterosaur Awaiting requested review from Pterosaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aputriax @prsunny @KrisNey-MSFT @chrispsommers