Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google Analyticsを追加 #311

Merged
merged 2 commits into from
Apr 26, 2024
Merged

feat: Google Analyticsを追加 #311

merged 2 commits into from
Apr 26, 2024

Conversation

appare45
Copy link
Member

close #304

@appare45 appare45 requested a review from arata-nvm April 26, 2024 01:43
@appare45 appare45 self-assigned this Apr 26, 2024
@appare45
Copy link
Member Author

これ、GTMとか使ってさくらのロゴのクリック回数など計測すると良かったりする?

Copy link
Member

@arata-nvm arata-nvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今の実装はNEXT_PUBLIC_GAIDが空の場合もhttps://www.googletagmanager.com/gtag/js?id=を取ってくるようになっていて、GTMのスクリプトが埋め込まれるのでそれが問題ないならよいと思います 👍
一応去年の実装は{NEXT_PUBLIC_GAID && <GoogleAnalytics>}のようになっているようです

@arata-nvm
Copy link
Member

これ、GTMとか使ってさくらのロゴのクリック回数など計測すると良かったりする?

その実装がそんなに難しくないなら埋め込んでおくと便利かも

Copy link

Deploying sos24-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ca6965
Status: ✅  Deploy successful!
Preview URL: https://aae8a19a.sos24-client.pages.dev
Branch Preview URL: https://feat--304-ga.sos24-client.pages.dev

View logs

Copy link
Member

@arata-nvm arata-nvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@appare45 appare45 merged commit 4fe41ca into develop Apr 26, 2024
5 checks passed
@appare45 appare45 deleted the feat/#304-ga branch April 26, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analyticsの導入
2 participants