Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentryを導入 #260

Merged
merged 9 commits into from
Apr 21, 2024
Merged

Sentryを導入 #260

merged 9 commits into from
Apr 21, 2024

Conversation

Myxogastria0808
Copy link
Member

close #85

@Myxogastria0808 Myxogastria0808 changed the title add sentry Sentryを導入 Apr 20, 2024
@Myxogastria0808
Copy link
Member Author

Myxogastria0808 commented Apr 20, 2024 •
edited
Loading

prettierのCIのエラーは、Sentryがエラーの通知をしているかどうか確認するために作成したファイルでエラーが出ていそうです。
エラーの通知が正しく出来ていることが確認出来ましたら、確認用に作成した src/app/sentry-example-page/page.jsxとsrc/app/api/sentry-example-api/route.jsを削除してからマージしていただけるとありがたいです。

@appare45 appare45 self-requested a review April 21, 2024 01:18
@Myxogastria0808 Myxogastria0808 self-assigned this Apr 21, 2024
@appare45 appare45 force-pushed the feat/#85-add-sentry branch from 094c83e to 70fb7e7 Compare April 21, 2024 09:50
@appare45
Copy link
Member

メモ: CDを動かすためにrebaseしました

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 21, 2024 •
edited
Loading

Deploying sos24-client with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f3bb42
Status: ✅  Deploy successful!
Preview URL: https://4c4d3488.sos24-client.pages.dev
Branch Preview URL: https://feat--85-add-sentry.sos24-client.pages.dev

View logs

@appare45
Copy link
Member

status: なぜかこれが報告される
修正方法わからず、解決で来なさそうだったら一旦マージ
https://sohosai-jsys.sentry.io/issues/5232484611/events/0420b9def96c4e04b5ebadd9ebfae42d/

appare45
appare45 reviewed Apr 21, 2024
View reviewed changes
sentry.client.config.ts
import * as Sentry from "@sentry/nextjs";

Sentry.init({
dsn: "https://46644e4ad167a3a09182716f44bc953d@o4507113970466816.ingest.us.sentry.io/4507114421747712",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Myxogastria0808 ここらへんって直書きして問題ないですか？

Copy link
Member Author

@Myxogastria0808 Myxogastria0808 Apr 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appare45
SentryのDocsに以下のような記載がありましたので、dsnを直書きしていても問題ないはずです。

DSN Utilization
DSNs are safe to keep public because they only allow submission of new events and related event data; they do not allow read access to any information.

引用元サイト: https://docs.sentry.io/product/sentry-basics/concepts/dsn-explainer/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

@appare45
Copy link
Member

@Myxogastria0808 ありがとうございました！

@appare45 appare45 merged commit 322a7b8 into develop Apr 21, 2024
5 checks passed
@appare45 appare45 deleted the feat/#85-add-sentry branch April 21, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appare45 appare45 appare45 left review comments

Assignees

@Myxogastria0808 Myxogastria0808

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentryを導入
2 participants
@Myxogastria0808 @appare45