Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile and add automatic docker build via github actions #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lfoppiano
Copy link
Contributor

@lfoppiano lfoppiano commented Nov 20, 2024

This PR:

  • updates the Dockerfile using the grobid-full image as a docker base
  • update the build so that the config.yaml is read and the grobid-home is correctly used for installing the models
  • update the build to support conda environments
  • add github actions for automatic build and unit test (now disabled, for when will have them)
  • add github actions for manual docker builds with push on docker hub. It's necessary to set up the secrets DOCKERHUB_USERNAME and DOCKERHUB_TOKEN

@kermitt2 I'm wondering whether we should use the CRF models or the DL (as of with this change)?

@lfoppiano lfoppiano marked this pull request as draft November 20, 2024 18:02
@lfoppiano lfoppiano marked this pull request as ready for review November 20, 2024 18:08
@lfoppiano lfoppiano changed the title add github actions update dockerfile and add automatic docker build via github actions Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant